Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diary to app list for translation #373

Merged
merged 2 commits into from
May 18, 2022

Conversation

danielroehrig
Copy link
Contributor

I would love for the diary app to be translated by the transifex nextcloud group. Hopefully, I did all the right changes in my app, but if I didn't, please contact me. ATM it's just one string that should be translated as a test. If it works, I will add all the others too. I invited nextcloud-bot to be a collaborator so that I can give it write access, but it didn't accept. I am following this guide here.

@rakekniven
Copy link
Member

rakekniven commented May 16, 2022

Hello @danielroehrig ,

just seen your PR.

Will work on it.

URL: https://github.com/danielroehrig/diary

Copy link
Member

@rakekniven rakekniven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Respect alphabetical order,
use spaces not tabs for indentation

@rakekniven
Copy link
Member

rakekniven commented May 16, 2022

@danielroehrig Please sign your commits using DCO by adding Signed-off-by: Author Name <authoremail@example.com> to your commit message.

Signed-off-by: Daniel Röhrig <mail@danielroehrig.de>
@rakekniven rakekniven merged commit 2c8470c into nextcloud:master May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants