Apache LimitRequestBody 0

[thechubbypanda]

Removes the 1GB upload restriction, allowing the PHP setting to work again.

Thanks to @t-schuster for the patch suggestion

Fixes #1796

[Etienne-Schmitt]

Can a maintaner validate this?
This is a real problem and having to mount a special config for apache or edit the .htaccess everytime work BUT is not as practical than this fix

[J0WI]

Unfortunately it's not as simple as that. You can read more about it here: https://docs.nextcloud.com/server/latest/admin_manual/configuration_files/big_file_upload_configuration.html

[t-schuster]

I still apply the same patch in my deployment, it is actually as simple as that.

[thechubbypanda]

We've all read the docs and come to the conclusion that this patch is literally the one thing stopping the PHP env variables from working fully. It is actually something that used to work until apache changed the default value for it.
Regardless, it is merely allowing for one less hurdle to jump through when trying to enable big file uploads.
I'd also point out that the docs are terrible. It took me 5 days to figure out what was going on and find this fix.
(I'm also aware I've messed up the brackets, will fix soon)

[Etienne-Schmitt]

Can confirm this, I'm using this only fix on my container and just this fixed the problem.

Like mention earlier in older version of apache2 the default value for LimitRequestBody was 0 before now it's set as 1GiB, as you can see here:
https://httpd.apache.org/docs/2.4/mod/core.html#limitrequestbody

Maybe for some people there will be more problems, like badly configured reverse proxy or else, but on the images library/nextcloud:*-apache "flavor" it will fix this upload problem.

[Etienne-Schmitt]

It even was discussed on the AOI images maintain by nextcloud:
nextcloud/documentation#10989

So, can we have progress on this?

Edit: the issue #1796 was even brough up on nextcloud/documentation#10989, and NEXTCLOUD/DOCUMENTATION say than MAYBE this should be merged or adapt into another form (directly edit the apache main apache2.conf? idk...)

Regards,
(Sorry for the caps, it's simple but it's driving me nuts...)

[J0WI]

I think I would prefer the implementation in #2065. That's a better compromise than setting it to unlimited for everyone.

[thechubbypanda]

Closing in favour of #2065