Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a new UI to be prepared for more options #35

Merged
merged 1 commit into from
May 30, 2017
Merged

Conversation

nickvergessen
Copy link
Member

The change needs to be done in preparation for #26
There is no way we can fit more options into the old single line table layout.

@nextcloud/designers can someone take a quick look if this is okay?

Before

Before

After

After

Signed-off-by: Joas Schilling <coding@schilljs.com>
Copy link
Member

@MariusBluem MariusBluem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bildschirmfoto 2017-05-30 um 12 14 14

@nickvergessen
Copy link
Member Author

As for 1.
Not sure, most URLs are longer (not domain roots, but specific pages) and we have the space, so I would just allow them to be longer.

As for 2.
I thought about it as well, also about closing one when you open another, but In the end I though it's better to keep them open, so you can easier copy settings from one entry to another.

@MariusBluem
Copy link
Member

As for 1.
Not sure, most URLs are longer (not domain roots, but specific pages) and we have the space, so I would just allow them to be longer.

Fine.

As for 2.
I thought about it as well, also about closing one when you open another, but In the end I though it's better to keep them open, so you can easier copy settings from one entry to another.

We have a whole admin-category, so it should not make too much noise 😅

@nickvergessen nickvergessen merged commit 2a396fe into master May 30, 2017
@nickvergessen nickvergessen deleted the new-ui branch May 30, 2017 10:31
@jancborchardt
Copy link
Member

This makes an overview very difficult. I’d have advised to keep the row layout, add table headers, focus on the important fields like name and link and put the additional things into a 3-dot menu since they are really way less important and probably mostly stay the default.

Now the layout is changed to mainly cater for the not-so-common usecases and looks veeery heavy. @nickvergessen could we change it back and rather go with the changes I mentioned?

@jancborchardt
Copy link
Member

We could even save a lot of space by simply using icons for things like the icon as you already mention in #36 – but language, devices and position are way less modified than name and link and should hence go in a popover instead of being as prominent as those fields.

@nickvergessen
Copy link
Member Author

Problem with popover is, I don't feel very comfortable putting a select2 group selector into it. When you find someone that does it, feel free to do it.

But I can try to make the name and url field show by default

@jancborchardt
Copy link
Member

jancborchardt commented Jun 4, 2017

Ok, maybe someone from @nextcloud/javascript can help then?

=> #37

@nickvergessen
Copy link
Member Author

@jancborchardt see #37 I think it's okay too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants