-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a new UI to be prepared for more options #35
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As for 1. As for 2. |
Fine.
We have a whole admin-category, so it should not make too much noise 😅 |
This makes an overview very difficult. I’d have advised to keep the row layout, add table headers, focus on the important fields like name and link and put the additional things into a 3-dot menu since they are really way less important and probably mostly stay the default. Now the layout is changed to mainly cater for the not-so-common usecases and looks veeery heavy. @nickvergessen could we change it back and rather go with the changes I mentioned? |
We could even save a lot of space by simply using icons for things like the icon as you already mention in #36 – but language, devices and position are way less modified than name and link and should hence go in a popover instead of being as prominent as those fields. |
Problem with popover is, I don't feel very comfortable putting a select2 group selector into it. When you find someone that does it, feel free to do it. But I can try to make the name and url field show by default |
Ok, maybe someone from @nextcloud/javascript can help then? => #37 |
@jancborchardt see #37 I think it's okay too |
The change needs to be done in preparation for #26
There is no way we can fit more options into the old single line table layout.
@nextcloud/designers can someone take a quick look if this is okay?
Before
After