Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish files app UI integration #6

Merged
merged 1 commit into from
Nov 27, 2019
Merged

Polish files app UI integration #6

merged 1 commit into from
Nov 27, 2019

Conversation

juliusknorr
Copy link
Member

Implements currently possible parts of #3

  • Add locked icon above 3-dots menu (while it is actually a bit a hacky apporach, it works quite well)
  • Use proper icon
  • Limit locking state to files

image
image
image
image

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@ArtificialOwl
Copy link
Member

@karlitschek wanted some screenshot !!

@juliushaertl I have an issue on my instance, but I guess it's only local. We can merge this and have a nice release pre-18. I will release a new version when nextcloud/server#18080 is merged

@ArtificialOwl ArtificialOwl merged commit 1b4a63f into master Nov 27, 2019
@delete-merged-branch delete-merged-branch bot deleted the enh/ui branch November 27, 2019 11:13
@karlitschek
Copy link
Member

Very nice. Would it be possible to show the avatar picture of the user who locked it? So you can click on it and chat/call/email with the person. @juliushaertl @daita

@ArtificialOwl
Copy link
Member

Right, that's would be a fun feature.

@jancborchardt
Copy link
Member

Yep, and it's also important to know who locked it :) not only for fun

@juliusknorr
Copy link
Member Author

Ongoing discussions for that are in #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants