-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use text editor for editing question description #2164
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2164 +/- ##
============================================
- Coverage 45.02% 44.89% -0.13%
- Complexity 720 725 +5
============================================
Files 61 62 +1
Lines 2776 2784 +8
============================================
Hits 1250 1250
- Misses 1526 1534 +8 |
bc3ff30
to
dc32473
Compare
@Koc sorry, I can't help you much with this... Regarding your questions:
|
@mejo- any idea? As far I can see you have experience with Collective + Text integration |
So regarding the attachment support: you'll have to provide your own implementation here, because you use the editor which is not file-based and instead gets the markdown content as a property via the API. The attachments support as you know it from Text and Collectives works because there the editor is file-based and attachments can be uploaded to a related attachments folder. As far as I know the content-based editor (different than the file-based editor) so far doesn't support adding attachments and images. The deck app has support to upload attachments via the button you referenced, but these attachments don't show up in the text document either, they just get listed as attachments. See here for the implementation. Regarding the bottom padding of the editor, that's the standard CSS of the editor and it needs to be overwritten. Again see the deck app how it's done there. |
4a29bdc
to
31c4f3a
Compare
Signed-off-by: Konstantin Myakshin <molodchick@gmail.com>
31c4f3a
to
2b19e93
Compare
I've achieved some progress with styling. You can see it on attached video in PR description. Next goal - make image upload work. |
Implementation of the images uploading functionality requires much more effort than I expected 😿 . At the same time for me it has no sense to provide UI editor without this functionality (as it was the root cause why I've started work on this task). We can return to this later |
Currently it is hard to write rich question descriptions for non-tech people. Would be nice add UI editor for that. Here some draft of this functionality. If text app isn't installed we fallback to simple textarea like it was before.
nextcloud-text-editor.mp4