Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access denied when opening files from shared group folder #225

Closed
klada opened this issue Nov 20, 2018 · 3 comments · Fixed by nextcloud/server#12708
Closed

Access denied when opening files from shared group folder #225

klada opened this issue Nov 20, 2018 · 3 comments · Fixed by nextcloud/server#12708

Comments

@klada
Copy link

klada commented Nov 20, 2018

When sharing an entire group folder through the normal user interface (share link) the permissions are broken/not checked correctly. The link is working for displaying the contents, but when opening a file I always get access denied.

Steps to reproduce:

  1. Create a new groupfolder and add a group with sharing permission
  2. Swith to the normal user UI, where the group folder now shows up
  3. Open the share dialog for the newly created group folder and create a share link with "write permissions".
  4. Create a new text file test.txt in the group folder
  5. Open a different browser/private window and use the share link
  6. You can see the test file test.txt in the directy listing. Click on the file.
  7. You now get access denied → this is wrong

When sharing a subfolder from within the group folder the share links are working as expected. This only applies when sharing the entire group folder.

Versions:

  • Nextcloud 14.0.3
  • Groupfolder 1.3.3
  • Collabora 3.0.5
@icewind1991
Copy link
Member

I can't reproduce this issue, opening files from a link-shared groupfolder works as expected

@klada
Copy link
Author

klada commented Nov 27, 2018

I think it has to do with Collabora, as it tries to open the txt file with it (for whatever reason). Did you try it with Collabora enabled?

@icewind1991
Copy link
Member

Ok, I can confirm this behavior with Collabora

icewind1991 added a commit to nextcloud/server that referenced this issue Nov 28, 2018
This fixes collabora on public link shared groupfolders

Fixes nextcloud/groupfolders#225

Signed-off-by: Robin Appelman <robin@icewind.nl>
backportbot-nextcloud bot pushed a commit to nextcloud/server that referenced this issue Nov 28, 2018
This fixes collabora on public link shared groupfolders

Fixes nextcloud/groupfolders#225

Signed-off-by: Robin Appelman <robin@icewind.nl>
backportbot-nextcloud bot pushed a commit to nextcloud/server that referenced this issue Nov 28, 2018
This fixes collabora on public link shared groupfolders

Fixes nextcloud/groupfolders#225

Signed-off-by: Robin Appelman <robin@icewind.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants