Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/repair cs fix #2113

Merged
merged 2 commits into from
Aug 12, 2023
Merged

Chore/repair cs fix #2113

merged 2 commits into from
Aug 12, 2023

Conversation

zak39
Copy link
Contributor

@zak39 zak39 commented Oct 3, 2022

I fix the cs command and replace by ".php-cs-fixer.php" and I create check the cs fix for php in the github workflow.

The php cs comment was broke and I renmad.

Signed-off-by: Baptiste Fotia <fotia.baptiste@hotmail.com>
to check the cs fix for php.

Signed-off-by: Baptiste Fotia <fotia.baptiste@hotmail.com>
@zak39 zak39 added 2. developing Items that are currently under development php Items related to PHP updates and code issues labels Oct 3, 2022
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the cache file to .gitignore

@zak39
Copy link
Contributor Author

zak39 commented Oct 5, 2022

Please add the cache file to .gitignore

Hi @nickvergessen 🙂

Is this line not sufficient to ignore the cache file ? 🤔

*.cache

@nickvergessen
Copy link
Member

Should be enough yes

@vitormattos vitormattos added 3. to review Items that need to be reviewed and removed 2. developing Items that are currently under development labels Oct 7, 2022
@CarlSchwan
Copy link
Member

Ping on this, it would be nice to have ;)

@susnux susnux merged commit b98790f into nextcloud:master Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Items that need to be reviewed php Items related to PHP updates and code issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants