Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow scanning all group folders #2214

Merged
merged 2 commits into from
Dec 27, 2022
Merged

Allow scanning all group folders #2214

merged 2 commits into from
Dec 27, 2022

Conversation

PVince81
Copy link
Member

@PVince81 PVince81 commented Dec 22, 2022 •
edited
Loading

Fixes #465

image

@PVince81 PVince81 added enhancement 3. to review Items that need to be reviewed labels Dec 22, 2022
@PVince81 PVince81 self-assigned this Dec 22, 2022
@PVince81 PVince81 mentioned this pull request Dec 22, 2022
Closed
@PVince81
Copy link
Member Author

now looking at my screenshot it looks like the stats are not really working

@PVince81
Allow scanning all group folders
6e3d73e 
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81 PVince81 force-pushed the enh/465/scan-all-groupfolders branch from 6543d94 to 6e3d73e Compare December 23, 2022 09:39
@PVince81
Copy link
Member Author

fixed stats and updated screenshot in top post

artonge
artonge approved these changes Dec 27, 2022
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides potential unused variable, looks good

lib/Command/Scan.php Outdated Show resolved Hide resolved
@icewind1991
remove unused attribute
e92b07b 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 merged commit 1643535 into master Dec 27, 2022
@icewind1991 icewind1991 deleted the enh/465/scan-all-groupfolders branch December 27, 2022 17:32
@joshtrichards joshtrichards mentioned this pull request Nov 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@icewind1991 icewind1991 icewind1991 approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@come-nc come-nc Awaiting requested review from come-nc

Assignees

@PVince81 PVince81

Labels
3. to review Items that need to be reviewed enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add groupfolders:scan --all option
3 participants
@PVince81 @icewind1991 @artonge