fix previews of files inside deleted folders #2334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #1998 Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
preview-deleted-folder
branch
from
31f1eb0
to
f2c2709
Compare
artonge
approved these changes
Apr 18, 2023
|
/backport to stable26 |
|
/backport to stable25 |
This was referenced Apr 18, 2023
|
@icewind1991 can you please say when release with this fix will be published? |
This was referenced Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1998
instead of getting the trash info for the file inside the folder, get the info of the folder that was deleted.
And add some failsafe in case the trash item isn't found for any reason