Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(settings): Calculate correct default quota option sizes #3161

Merged
merged 1 commit into from
Sep 4, 2024
Merged

fix(settings): Calculate correct default quota option sizes #3161

merged 1 commit into from
Sep 4, 2024

Conversation

provokateurin
Copy link
Member

@provokateurin provokateurin commented Sep 3, 2024 •
edited
Loading

I first noticed the unit was wrong, decimal vs binary notation.
Then I realized the values were wrong too, not sure why this is so messed up:

1073741274 -1024^3   =-550
5368709120 -1024^3*5 = 0
10737412742-1024^3*10=-5498

Really weird how one is correct, one is off by a bit and the other that should be 10x off is slight less off than 10x??

Should we add a migration that corrects these quota values if they are configured for existing groupfolders?

@provokateurin provokateurin added bug 3. to review Items that need to be reviewed labels Sep 3, 2024
artonge
artonge approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A migration sounds good, else admins will see a custom set quota, no?

@provokateurin
Copy link
Member Author

provokateurin commented Sep 3, 2024 •
edited
Loading

Yeah, it looks weird now as it says 1,024 MB for the previous 1 GB option.

@provokateurin provokateurin force-pushed the fix/settings/default-quota-option-sizes branch from 2eaa71e to 8f0845b Compare September 3, 2024 13:32
@provokateurin
Copy link
Member Author

Repair step added

@provokateurin
Copy link
Member Author

/backport to stable30

@provokateurin
Copy link
Member Author

/backport to stable29

@provokateurin
Copy link
Member Author

/backport to stable28

@provokateurin provokateurin force-pushed the fix/settings/default-quota-option-sizes branch from 8f0845b to 248d14d Compare September 4, 2024 06:20
@provokateurin provokateurin added 4. to release Items that are ready for releasing and removed 3. to review Items that need to be reviewed labels Sep 4, 2024
@provokateurin
fix(settings): Calculate correct default quota option sizes
50280c9 
Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin force-pushed the fix/settings/default-quota-option-sizes branch from 248d14d to 50280c9 Compare September 4, 2024 06:21
@provokateurin
Copy link
Member Author

Can someone merge? The failures are unrelated to the changes :/

@skjnldsv skjnldsv merged commit 6f86aaa into master Sep 4, 2024
42 of 45 checks passed
@skjnldsv skjnldsv deleted the fix/settings/default-quota-option-sizes branch September 4, 2024 07:55
This was referenced Sep 4, 2024
Merged
Merged
@backportbot backportbot bot mentioned this pull request Sep 4, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Altahrim Altahrim Altahrim left review comments

@skjnldsv skjnldsv skjnldsv approved these changes

@artonge artonge artonge approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner

@come-nc come-nc Awaiting requested review from come-nc come-nc is a code owner

Assignees
No one assigned
Labels
4. to release Items that are ready for releasing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@provokateurin @Altahrim @artonge @skjnldsv