Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not define loadBalancerIP on service unless set in values #428

Closed
benyanke opened this issue Aug 17, 2023 · 0 comments · Fixed by #430
Closed

Do not define loadBalancerIP on service unless set in values #428

benyanke opened this issue Aug 17, 2023 · 0 comments · Fixed by #430

Comments

@benyanke
Copy link
Contributor

Describe your Issue

Here, the loadBalancerIP field is unconditionally set. However, this is not always ideal, as in some architectures, you don't need to pass it through, instead allowing a tool like MetalLB, or even a custom mutating admission controller (which I have also done personally) which can set that field for you.

The nil field might work in some contexts, but given that a valid kubernetes service can exist without that field set in the initial manifest, I would argue the NextCloud helmchart ought to do the same. If the user cares about a specific IP being there, they'll set it. If they have not set it, it would seem the most expected and intuitive behavior would similarly be to not set it on the service.

Additional sections removed as they're arguably not applicable here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant