You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Here, the loadBalancerIP field is unconditionally set. However, this is not always ideal, as in some architectures, you don't need to pass it through, instead allowing a tool like MetalLB, or even a custom mutating admission controller (which I have also done personally) which can set that field for you.
The nil field might work in some contexts, but given that a valid kubernetes service can exist without that field set in the initial manifest, I would argue the NextCloud helmchart ought to do the same. If the user cares about a specific IP being there, they'll set it. If they have not set it, it would seem the most expected and intuitive behavior would similarly be to not set it on the service.
Additional sections removed as they're arguably not applicable here.
The text was updated successfully, but these errors were encountered:
Describe your Issue
Here, the
loadBalancerIP
field is unconditionally set. However, this is not always ideal, as in some architectures, you don't need to pass it through, instead allowing a tool like MetalLB, or even a custom mutating admission controller (which I have also done personally) which can set that field for you.The
nil
field might work in some contexts, but given that a valid kubernetes service can exist without that field set in the initial manifest, I would argue the NextCloud helmchart ought to do the same. If the user cares about a specific IP being there, they'll set it. If they have not set it, it would seem the most expected and intuitive behavior would similarly be to not set it on the service.Additional sections removed as they're arguably not applicable here.
The text was updated successfully, but these errors were encountered: