Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nginx containerPort confusion #545

Open
Zalfsten opened this issue Mar 13, 2024 · 4 comments
Open

nginx containerPort confusion #545

Zalfsten opened this issue Mar 13, 2024 · 4 comments
Labels
bug Something isn't working good first issue Small tasks with clear documentation about how and in which place you need to fix things in. nginx container issues related to the nginx container bundling in the nextcloud pod.

Comments

@Zalfsten
Copy link

Hello,

I'm trying to setup nextcloud with root-less nginx. So the default nginx port 80 won't work.
Thus I've set nextcloud.nginx.containerPort to 8080. This results in probe failures, because the nginx probes still refer to port 80.

Having a look at the chart templates, I notice that nextcloud.nginx.containerPort is only used for the nginx config, but not when settings up the container in the deployment. The nginx container make use of nextcloud.nextcloud.containerPort instead. I would consider this to be a bug.

On the other hand, when enabling nginx, nextcloud.nextcloud.containerPort is used only for the nginx container, not at all for the nextcloud container. So the simple workaround is to set nextcloud.nginx.containerPort and nextcloud.nextcloud.containerPort simultaneaously.

Still, I find this confusing. I would either join both variables into one or keep them completely separate -- i.e. the nginx container only uses nextcloud.nginx.containerPort, never the nextcloud.nextcloud.containerPort.

Regards,
Carsten

@provokateurin
Copy link
Member

I agree, the situation is not good. I'd say the proper fix is to use the right variables in the right places, but not to merge them (could still be useful in edge cases). Would you be up for creating a PR?

@provokateurin provokateurin added the bug Something isn't working label Mar 13, 2024
@Zalfsten
Copy link
Author

Ok, I will try...

@jessebot jessebot added the good first issue Small tasks with clear documentation about how and in which place you need to fix things in. label May 1, 2024
@suyash-811
Copy link

Is the issue still open? I could work on this.

@jessebot
Copy link
Collaborator

I believe this is still available for work. I don't think I've seen a PR for this.

@jessebot jessebot added the nginx container issues related to the nginx container bundling in the nextcloud pod. label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Small tasks with clear documentation about how and in which place you need to fix things in. nginx container issues related to the nginx container bundling in the nextcloud pod.
Projects
None yet
Development

No branches or pull requests

4 participants