Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix helm GitHub Actions version constraints and bump to latest #376

Merged
merged 2 commits into from
Apr 10, 2023

Conversation

jessebot
Copy link
Collaborator

@jessebot jessebot commented Apr 10, 2023

Pull Request

Description of the change

Fixed because:

Looks like this is due to the helm org not releasing tags like v1.5, instead of only v1.5.0, unlike the azure/setup-helm github action, which does tag for minor versions like v3.5.

Also bumped kind action version from 1.4 -> 1.5.

Benefits

Fixes the issues shown here:

Screenshot 2023-04-10 at 18 28 58

Additional information

Checklist

Fixed because:
- helm/kind-action does not create tags for minor versions with no patch version: https://github.com/helm/kind-action/tags
- helm/chart-testing-action does not create tags for minor versions with no patch version: https://github.com/helm/chart-testing-action/tags

Signed-off-by: JesseBot <jessebot@linux.com>
@jessebot jessebot self-assigned this Apr 10, 2023
helm/chart-releaser does not create tags for minor versions without patch version, so we can't relax this right now: https://github.com/helm/chart-releaser-action/tags

Signed-off-by: JesseBot <jessebot@linux.com>
@jessebot jessebot changed the title lint-test.yaml: fix helm/kind-action & helm/chart-testing lint-test.yaml: fix helm GitHub Actions and bump to latest Apr 10, 2023
@jessebot jessebot marked this pull request as ready for review April 10, 2023 16:30
@jessebot jessebot changed the title lint-test.yaml: fix helm GitHub Actions and bump to latest Fix helm GitHub Actions version constraints and bump to latest Apr 10, 2023
@jessebot jessebot merged commit ed3b4dc into master Apr 10, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix/github-action-versions branch April 10, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants