Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added redis password to config #56

Closed
wants to merge 2 commits into from

Conversation

healthsyscn
Copy link

Following up #54 to add the redis password to the redis.config.php file

@tvories
Copy link
Collaborator

tvories commented Jan 16, 2021

@billimek this definitely appears needed to complete the fix in #54

@billimek
Copy link
Contributor

billimek commented Feb 5, 2021

Hi Hi @healthsyscn can you please sign the DCO and bump the chart version in the Chart.yaml file in order to signify a change in the chart?

At the time of this writing, 2.5.3 is probably a good version to use.

Signed-off-by: Taylor <taylor@tmtech.me>
@tvories
Copy link
Collaborator

tvories commented Feb 5, 2021

@healthsyscn I already modified the chart version number if you can sign the DCO.

@ishioni
Copy link
Contributor

ishioni commented Feb 6, 2021

Guys, i just checked a fresh install (with patches included), and it seems that nextcloud refuses to work with redis 6 and an empty password. I'm getting 303 replies when logging in and absolutely no log output about the problem. Can someone confirm it SHOULD work? Otherwise we should set some default password

@tvories
Copy link
Collaborator

tvories commented Feb 6, 2021

@ishioni I would agree that we should default to a password even if none is provided to resolve the redis 6 password woes. I'll see if I can get something pushed here that fixes that.

@tvories
Copy link
Collaborator

tvories commented Feb 18, 2021

I'm going to approve this and we can track the "setting a default password" conversation in another issue.

@tvories
Copy link
Collaborator

tvories commented Feb 24, 2021

This has been addressed in #89 along with some other improvements. Closing in favor of that PR.

@tvories tvories closed this Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants