-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added initContainer to fix mariadb initial connection failing #67
Conversation
This works great for my case, I'll use this fork until this is merged, hopefully soon! Thanks. Looks like you need to bump the version to 2.5.2, since 2.5.1 was already released a few days ago. |
@wikoion can you please sign the DCO so the contribution can be accepted? In addition, the chart version needs to be bumped again. I suggest using |
@wikoion you would need to bump it to |
@tvories I don't know why, but I cannot get this DCO to work 🤦 Could you explain what I have to do so I know I'm not just being stupid? |
I had to do this the other day. You will probably need to sign off on previous commits. Try one of these fixes? https://stackoverflow.com/questions/25570947/how-to-use-git-interactive-rebase-for-signing-off-a-series-of-commits You should be able to checkout whichever commits you haven't signed and do a |
Signed-off-by: Richard Draycott <rich@wikoion.dev>
Signed-off-by: Richard Draycott <rich@wikoion.dev>
Signed-off-by: Richard Draycott <rich@wikoion.dev>
Ah okay yeah, that was the issue, I squashed all the commits with sign of and has worked now. I've pulled in the latest changes from master and bumped the version again, so should be good now? |
Nice work! Merging! |
This is to fix #60. I'm running this fork in prod now. a similar initcontainer could be added for postgress in the same way. More of an idea than anything, if there's anything you want me to change, or you want to take this and improve it to fit your needs that's fine.