Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added initContainer to fix mariadb initial connection failing #67

Merged
merged 3 commits into from
Feb 16, 2021

Conversation

wikoion
Copy link
Contributor

@wikoion wikoion commented Jan 24, 2021

This is to fix #60. I'm running this fork in prod now. a similar initcontainer could be added for postgress in the same way. More of an idea than anything, if there's anything you want me to change, or you want to take this and improve it to fit your needs that's fine.

@tcardonne
Copy link
Contributor

tcardonne commented Feb 3, 2021

This works great for my case, I'll use this fork until this is merged, hopefully soon! Thanks.

Looks like you need to bump the version to 2.5.2, since 2.5.1 was already released a few days ago.

@billimek
Copy link
Contributor

billimek commented Feb 4, 2021

@wikoion can you please sign the DCO so the contribution can be accepted?

In addition, the chart version needs to be bumped again. I suggest using 2.5.2.

@tvories
Copy link
Collaborator

tvories commented Feb 15, 2021

@wikoion you would need to bump it to 2.5.4 at this point. Any way I could get you to sign the DCO?

@wikoion
Copy link
Contributor Author

wikoion commented Feb 16, 2021

@tvories I don't know why, but I cannot get this DCO to work 🤦 Could you explain what I have to do so I know I'm not just being stupid?

@tvories
Copy link
Collaborator

tvories commented Feb 16, 2021

I had to do this the other day. You will probably need to sign off on previous commits. Try one of these fixes? https://stackoverflow.com/questions/25570947/how-to-use-git-interactive-rebase-for-signing-off-a-series-of-commits

You should be able to checkout whichever commits you haven't signed and do a git commit --amend --signoff --no-edit on each of them.

Signed-off-by: Richard Draycott <rich@wikoion.dev>
Signed-off-by: Richard Draycott <rich@wikoion.dev>
Signed-off-by: Richard Draycott <rich@wikoion.dev>
@wikoion
Copy link
Contributor Author

wikoion commented Feb 16, 2021

Ah okay yeah, that was the issue, I squashed all the commits with sign of and has worked now. I've pulled in the latest changes from master and bumped the version again, so should be good now?

@tvories
Copy link
Collaborator

tvories commented Feb 16, 2021

Nice work! Merging!

@tvories tvories merged commit 64276b7 into nextcloud:master Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

file CAN_INSTALL is missing from your config directory
4 participants