src/Room.vue: buttons to join via App (desktop and mobile) #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds 2 buttons at the bottom of the Room page which allow users to join a Jitsi room via the Jitsi Desktop app and the Jitsi Mobile app, respectively. The change moves calculations of the coresponding join URLs into `computed()` as the button URLs are required when the page loads. Joining with the desktop app requires the URL to be prefixed with `jitsi-meet://`, while the mobile app requires `http[s]://`. The "Join using the Jitsi App" section was updated to provide help for joining with the Jitsi app. The calculated join HTTPS URL is re-used there; a user may fall back to pasting this URL into the Jitsi app should the buttons not work for them. Signed-off-by: Thilo Fromm <thilo.alexander@gmail.com>
t-lo
force-pushed
the
t-lo/add-jitsi-app-buttons
branch
from
3c11bd8
to
9749683
Compare
Closed
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
|
Rebased on latest master. |
|
Oh - next time please assign me as reviewer. Otherwise I may miss the notifications. |
|
I may open another PR soon to tweak some points… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds 2 buttons at the bottom of the Room page which allow users to join a Jitsi room via the Jitsi Desktop app and the Jitsi Mobile app, respectively.
The change moves calculations of the corresponding join URLs into
computed()as the button URLs are required when the page loads. Joining with the desktop app requires the URL to be prefixed withjitsi-meet://, while the mobile app requireshttp[s]://.The "Join using the Jitsi App" section was updated to provide help for joining with the Jitsi app. The calculated join HTTPS URL is re-used there; a user may fall back to pasting this URL into the Jitsi app should the buttons not work for them.
Tested on Linux (Fedora 36) with Chrome (106.0.0.0) and Firefox (105.0), on Windows 11 with Edge (105.0.1343.53) and Firefox (104.0), and on Android 12 with Firefox (105.0) and Chrome (105.0.0.0).
Resolves #8 .
Screenshots
PC
Android