fix: polish list item #10022
Merged
fix: polish list item #10022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
requested changes
Aug 20, 2024
ChristophWurst
requested changes
Aug 20, 2024
src/components/Envelope.vue
Outdated
| @@ -1072,13 +1072,19 @@ export default { | |||
| } | |||
| :deep(.list-item) { | |||
| flex-wrap: wrap; | |||
| padding: var(--default-grid-baseline); | |||
There was a problem hiding this comment.
Could you move this into the skeleton component? list item is our own component now. we don't need the deep selectors to patch styles
src/components/Envelope.vue
Outdated
| } | ||
| :deep(.line-two__subtitle) { | ||
| display: flex; | ||
| flex-basis: 100%; | ||
| padding-left: 40px; | ||
| width: 450px; | ||
| } | ||
| :deep(.list-item__actions) { |
ChristophWurst
approved these changes
Aug 20, 2024
the ellipsis happen only when there are too many tags, up to 3 its shown correctly, unless these 3 have longer translations or are personalized ones with long strings. But yes, i agree with you. |
Signed-off-by: greta <gretadoci@gmail.com>
GretaD
force-pushed
the
fix/polish-listitem
branch
from
b39596e
to
b48317d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request:
after. Please notice that the avatar is already 40px
