Move recipient delete to separate query #4932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesselb
reviewed
Apr 9, 2021
ChristophWurst
previously requested changes
Apr 12, 2021
|
More reviews |
kesselb
previously requested changes
Apr 20, 2021
The sub query did not use proper indexes. So now we just fetch the data and then issue a separate delete statement that can use all the right indexes. Resulting esp on large setups on a lot better performance. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
miaulalala
force-pushed
the
enh/recipients_delete_sep_query
branch
from
3f7a6ed
to
722de4a
Compare
miaulalala
approved these changes
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sub query did not use proper indexes. So now we just fetch the data
and then issue a separate delete statement that can use all the right
indexes. Resulting esp on large setups on a lot better performance.
Now truth be told I did not test this.
Lets see if it is covered by tests :P