Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix only one item marked as read by Feed API #1687

Merged
merged 3 commits into from
Mar 8, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ The format is mostly based on [Keep a Changelog](https://keepachangelog.com/en/1
### Changed

### Fixed
- Fix only one item marked as read by Feed API (#1687)

# Releases
## [18.0.0] - 2022-02-23
Expand Down
2 changes: 1 addition & 1 deletion lib/Controller/FeedApiController.php
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ public function delete(int $feedId)
*/
public function read(int $feedId, int $newestItemId): void
{
$this->itemService->read($this->getUserId(), $feedId, $newestItemId);
$this->feedService->read($this->getUserId(), $feedId, $newestItemId);
}


Expand Down
2 changes: 1 addition & 1 deletion tests/Unit/Controller/FeedApiControllerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ public function testCreateError()

public function testRead()
{
$this->itemService->expects($this->once())
$this->feedService->expects($this->once())
->method('read')
->with($this->userID,3,30);

Expand Down