Port admin settings to vue

[CarlSchwan]

No description provided.

[CarlSchwan]

Ended up also fixing the 25 compatibility issue as it was only a 4 lines change

[Grotax]

Hi thanks for working on this :)

Currently I can't get this running, I only see a white page in the admin settings.
The Browser console complains that it can't load "http://localhost:8080/apps/news/js/news-admin-settings.js?v=574f49ba-0"

I just ran make in the news directory and checked it with the builtin php server

[CarlSchwan]

Hi thanks for working on this :)

Currently I can't get this running, I only see a white page in the admin settings. The Browser console complains that it can't load "http://localhost:8080/apps/news/js/news-admin-settings.js?v=574f49ba-0"

I just ran make in the news directory and checked it with the builtin php server

Should be fixed, I forgot to add it to the makefile

[Grotax]

The build issue is solved 👍

While checking the settings I noticed that the top setting for useCronUpdates does not behave correctly.
By default it should be set to true: https://github.com/nextcloud/news/blob/master/lib/AppInfo/Application.php#L60

But in the UI the switch is set to false, if you then switch it to true it actually get's saved as false in the DB.
At least in sqlite I see the field saved as 0.

[Grotax]

After quick test in my dev setup it seems to work now, changing the settings works as expected.

I will do more tests later.

[Grotax]

I checked again, here are some things I noticed.

When changing a value in the admin settings there is no indicator if the change was saved or not, I think an indicator would be good.

Running make placed three files in the /js dir I think those should land in /js/build dir. Additionally they need to be copied like the other files to the sign dir, there is still a line to copy the old admin js.

[Grotax]

The failing test is of course also a problem, I think the issue is that the cron setting useCronUpdates is now saved as 1/0 in the DB
While it used to be true/false. Could the UI use true/false booleans instead?

[Grotax]

Oh turns out the app config does not support booleans so we need to deal with it :)

[Grotax]

I think with these changes it should work, tests run locally and I tested it in my dev instance and the toggle seems to behave like it should

[Grotax]

Looks good, only thing I'm missing is a visual indicator for successful saving :)

[CarlSchwan]

Looks good, only thing I'm missing is a visual indicator for successful saving :)

Oh right, I forgot about it

[Grotax]

I think the explore.scss can be deleted :)

[anoymouserver]

While renaming the mobile.scss the 1024px instead of $breakpoint_mobile went missing again.

[CarlSchwan]

While renaming the mobile.scss the 1024px instead of $breakpoint_mobile went missing again.

Fixed

[anoymouserver]

The code looks good to me, I haven't tested it though.

[Grotax]

The success message is not popping up.

Error message works though.
Start php server load settings page, kill php server.
Change value -> Error Message 👍

[Grotax]

nvm, seems to be related to my dev setup.

I upgraded my test vm to NC25 and it worked, before that also tested on nc 24 also fine :)

[CarlSchwan]

Thanks for merging :) I'll try to find some free time to port the main webui to vue but can't promise any ETA