Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the updater. #1961

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Test the updater. #1961

merged 1 commit into from
Mar 24, 2023

Conversation

Grotax
Copy link
Member

@Grotax Grotax commented Oct 24, 2022

This is an experiment to explore ways to test the updater and later on also the purging.

I decided to build a small CLI tool on php basis using feed-io to generate feeds, based on the needs of testing.
https://github.com/Grotax/php-feed-generator lives in it's own repository due to issues with the import of the existing setup.
It was much easier to use the latest version of feed-io. Maybe at some point the tool can move into this repo.

The two first tests don't do anything amazing as of now, but I do have some ideas what could be done.
Until it actually brings some benefit I will leave it as a draft.

@Grotax Grotax added the Skip-Changelog No changelog update is required, minor change label Oct 25, 2022
@Grotax Grotax force-pushed the test/update branch 9 times, most recently from dc16514 to b617b3b Compare October 31, 2022 10:29
@Grotax Grotax force-pushed the test/update branch 4 times, most recently from 1354bb4 to 09e7399 Compare January 29, 2023 19:22
@Grotax Grotax force-pushed the test/update branch 2 times, most recently from 7ba4377 to d6fcc54 Compare March 21, 2023 16:48
@Grotax Grotax marked this pull request as ready for review March 21, 2023 16:49
@Grotax
Copy link
Member Author

Grotax commented Mar 21, 2023

So a few months later... I have added more tests.
There was at least one surprise during my testing: the fact that the individual feed item limit stays, even if the number shrinks in future updates. This fact is explained in our code with a comment and I trust that.

I adjusted the docs therefore a bit to explain this a bit better.

Now the testing doesn't do anything amazing and like this won't be able to catch all possible mistakes in the updater but at least the basics are covered. Maybe this can be extended in the future.

Ready for review. Not yet tested with #2119

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
@Grotax
Copy link
Member Author

Grotax commented Mar 23, 2023

Also works with #2119 - I'm happy with the current state :) I will merge this soon.

@Grotax Grotax merged commit 84c2ba5 into master Mar 24, 2023
@Grotax Grotax deleted the test/update branch March 24, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Skip-Changelog No changelog update is required, minor change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant