Fix ONLY_FULL_GROUP_BY #80 #406
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SMillerDev
requested changes
Mar 7, 2019
.travis.yml
Outdated
| @@ -41,6 +41,8 @@ before_script: | |||
| - if [[ "$DB" == 'mysql' ]]; then mysql -u root -e 'CREATE DATABASE oc_autotest;'; fi | |||
| - if [[ "$DB" == 'mysql' ]]; then mysql -u root -e "CREATE USER 'oc_autotest'@'localhost' IDENTIFIED BY 'oc_autotest';"; fi | |||
| - if [[ "$DB" == 'mysql' ]]; then mysql -u root -e "GRANT ALL ON oc_autotest.* TO 'oc_autotest'@'localhost';"; fi | |||
| - if [[ "$DB" == 'mysql' ]]; then mysql -u root -e "SET GLOBAL sql_mode = 'ONLY_FULL_GROUP_BY';"; fi | |||
There was a problem hiding this comment.
Can we make this an extra test? Maybe also one with STRICT_MODE?
Grotax
force-pushed
the
only_full_group_by
branch
3 times, most recently
from
4693972
to
d5f5c7c
Compare
Switch to xenial. Set sql_mode to `STRICT_ALL_TABLES, ONLY_FULL_GROUP_BY`
Grotax
force-pushed
the
only_full_group_by
branch
from
d5f5c7c
to
f1eb28c
Compare
Talon24
added a commit
to Talon24/news
that referenced
this pull request
Mar 8, 2019
Talon24
added a commit
to Talon24/news
that referenced
this pull request
Mar 22, 2019
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Grotax
pushed a commit
to Talon24/news
that referenced
this pull request
Mar 1, 2020
Grotax
pushed a commit
to Talon24/news
that referenced
this pull request
Mar 1, 2020
Talon24
added a commit
to Talon24/news
that referenced
this pull request
Mar 1, 2020
…xtcloud#406) Signed-off-by: Talon <talontalon24@gmail.com>
Merged
Grotax
added a commit
that referenced
this pull request
Mar 18, 2020
Changed - Basic Media-RSS support (#599) - Database index improvements (#637) Fixed - Call to a member function getUrlHash() on null" when adding a feed (#640) - Don't install symfony/console via composer (#636) - Fix for for ONLY_FULL_GROUP_BY (see #406) (Issue #80) (#407) - Catch invalid feeds (#646) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not really sure about this.
But it seems to work.
I didn't get my local mysql to enforce
ONLY_FULL_GROUP_BY.This might affect the speed of the query. I didn't find another way yet.
I will do some cleanup/rebase on the commits and travis file later.