Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if $feed is null #646

Merged
merged 2 commits into from
Mar 9, 2020
Merged

Check if $feed is null #646

merged 2 commits into from
Mar 9, 2020

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Mar 9, 2020

and we are unable to continue because there is no valid feed data

Peek 2020-03-09 18-36

Ref #640

and we are unable to continue because there is no valid feed data

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Copy link
Contributor

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make a test?

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@SMillerDev SMillerDev merged commit 58ec27e into master Mar 9, 2020
@delete-merged-branch delete-merged-branch bot deleted the feed-can-be-null branch March 9, 2020 22:03
@Grotax Grotax mentioned this pull request Mar 12, 2020
Grotax added a commit that referenced this pull request Mar 18, 2020
Changed
- Basic Media-RSS support (#599)
- Database index improvements (#637)

Fixed
- Call to a member function getUrlHash() on null" when adding a feed (#640)
- Don't install symfony/console via composer (#636)
- Fix for for ONLY_FULL_GROUP_BY (see #406) (Issue #80) (#407)
- Catch invalid feeds (#646)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants