Basic Media-RSS support

[azmeuk]

This is an attempt to tackle #570

This adds support for media thumbnails and description, available since Feedio 4.5.

Now youtube feeds display correctly:

I am not a PHP expert, neither an angular one, so I am not really used to good practices with those tools. Do not hesitate to tell me if there is anything I can improve.

[SMillerDev]

I'm not entirely sure if this should be a new element. Wouldn't you be able to represent the new images and description in the current datamodel?

[azmeuk]

Wouldn't you be able to represent the new images and description in the current datamodel?

Do you mean for example directly add some HTML into the feed content to avoid store the thumbnail and the description in new elements?

The current data model has those elements:

    /** @var string|null */
    protected $contentHash;
    /** @var string */
    protected $guidHash;
    /** @var string */
    protected $guid;
    /** @var string|null */
    protected $url;
    /** @var string|null */
    protected $title;
    /** @var string|null */
    protected $author;
    /** @var int|null */
    protected $pubDate;
    /** @var int|null */
    protected $updatedDate;
    /** @var string|null */
    protected $body;
    /** @var string|null */
    protected $enclosureMime;
    /** @var string|null */
    protected $enclosureLink;
    /** @var int */
    protected $feedId;
    /** @var int */
    protected $status = 0;
    /** @var string|null */
    protected $lastModified = '0';
    /** @var string|null */
    protected $searchIndex;
    /** @var bool */
    protected $rtl = false;
    /** @var string|null */
    protected $fingerprint;
    /** @var bool */
    protected $unread = false;
    /** @var bool */
    protected $starred = false;

I do not see pertinent attributes to store the thumbnail. We could store the description in $body, but according to the Media-RSS specification, the description of a media element is not the same thing as the feed content (even if for youtube feeds, it actually is). Do you have an idea to improve the implementation I proposed?

I understand that in fact the whole media model should be reworked, since a feed item can host several medias, but the current model only allows to manage one.

[SMillerDev]

Maybe you can add a description field only and make the thumbnail the media?

[azmeuk]

Technically that would work, but it seems to me that it would not be a good model representation of what a media is. The MediaRSS specification details a lot of attributes for a media object, including a thumbnail. Youtube and Peertube feeds for example provides both a media URL and a thumbnail URL. I suppose a good way for nextcloud-news to take benefit of this would be to display the thumbnail when the player is not available.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[azmeuk]

Please stalebot let this issue live.

[Grotax]

Didn't have the time to review this, yet 😅

[Grotax]

I think this is fine, @SMillerDev what do you think?

[Grotax]

Thanks @azmeuk sorry for the delay.

[user858753257]

I have added a youtube feed to my list. But the content view is empty. So now video preview....

[azmeuk]

What is the link of your Youtube feed? I works like a charm for mines.

[user858753257]

What is the link of your Youtube feed? I works like a charm for mines.

For testing purpose i have used this

https://www.youtube.com/channel/UCbiGcwDWZjz05njNPrJU7jA

[Grotax]

I tested your url and it works fine.

[user858753257]

I think the latest update have resolved my issue .