Different solution for ONLY_FULL_GROUP_BY (see #406) (Issue #80) #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grotax
approved these changes
Mar 25, 2019
|
@SMillerDev any comments or can we merge this? |
|
@marco44 could you check this pr and do a review, it has been hanging around for quite some time now but I think it's still relevant |
|
Yeah, that's way much better than what previous queries did (functional dependency on PK in group by is risky and all SQL engines behave differently on this, so better not rely on it). It's not going to be that costlier (microseconds probably) anyway |
|
closed it by accident :/ |
…xtcloud#406) Signed-off-by: Talon <talontalon24@gmail.com>
Signed-off-by: Talon <talontalon24@gmail.com>
This was referenced Mar 12, 2020
Merged
Grotax
added a commit
that referenced
this pull request
Mar 18, 2020
Changed - Basic Media-RSS support (#599) - Database index improvements (#637) Fixed - Call to a member function getUrlHash() on null" when adding a feed (#640) - Don't install symfony/console via composer (#636) - Fix for for ONLY_FULL_GROUP_BY (see #406) (Issue #80) (#407) - Catch invalid feeds (#646) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a different approach to #80 .
Here, we apply the aggregate functions in a subquery and get the defails from the
feedstable in the outer query.This makes it easer to see what we are counting and by what we are grouping by. Also, we don't have to include every column from
feedsin thegroup by.This uses subqueries rather than a
withclause as MySQL only supports that in version 8 upwards.Also, the table of origin has been added to
unread, as all other columns are referenced this way.This PR is meant to be an alternative to #406 in consultation with @Grotax to put both ways up for discussion.