removes unread-condition to respect all items while purging #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renames method to unmisleading `deleteOlderThanThreshold`
|
I am unable to fix the tests since i do not understand them and it is too complicated to build a testing environment. Sorry. |
1 task
|
This leads to data loss. Please discuss a solution first before creating a PR |
|
I won't merge this, as it brings a unexpected change to the current behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it makes no sense to keep old items regardless whether they are read or not. If an item is too old its no news anymore and should be removed - as well as read items. Only keep starred items.