#528 Save the excerpt in a separate column #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also load excerpt, when content is not pruned
|
Oh, nice! Yep, I will review and test this in detail, soon. Looks good on my first view :-) |
korelstar
reviewed
Dec 27, 2019
app/src/main/java/it/niedermann/owncloud/notes/persistence/NoteSQLiteOpenHelper.java
Outdated
Show resolved
Hide resolved
|
Nice :) I noticed a problem while upgrading from previous versions (and patched that in this branch) - maybe you could do a test from an old version too when you are over it. |
korelstar
approved these changes
Dec 27, 2019
There was a problem hiding this comment.
Great result: I have many (184) notes on my aged smartphone (Wileyfox Swift). Loading the notes list after starting the app took round about two seconds. With these changes, it takes round about one second. That's a very good improvement!
I added some commits in order to fix some things. Works for me now, I had not any problems during update.
|
Thank you for the review and the fixes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do you want to make a review since you requested this originally in #154