-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "TypeError: t is undefined" #1264
Conversation
vue created does not guaranteed that all refs filled. Sometime $refs.editor is undefined. Also an extra tick like in line 84 does not help. using mounted instead of created fixes this issues Signed-off-by: Holger Hees <holger.hees@gmail.com>
@juliushaertl is there anything missing or something I can do? |
@korelstar could you verify this? :) Also @mejo- @max-nextcloud maybe one of you can check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, makes sense 👍
CI failures are unrelated, will check separately |
@mchiappinam That's most likely a different issue. Your exception says Please open a separate issue. |
vue "created" does not guaranteed that all refs are filled. Sometime $refs.editor is undefined. Also an extra tick like in line 84 does not help.
created() is great for calling APIs, while mounted() is great for doing anything after the DOM elements have completely loaded.
using "mounted" instead of "created" fixes this issues
the bug itself is documented here
#1259