-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
group list of notes by timeslots #313
Conversation
@korelstar sorry for the late review! Looks very good, just 1 thing: Right now the headings are more important than the actual notes. Instead, these subheadings would be better in half-grey ( |
Currently, it's just the default style for navigation labels from server. But I will change that ... Thanks :-) |
@korelstar yes, we need to standardize that. :) cc @nextcloud/vue – but implementation (in several use-cases) comes before standardization. :) Thank you! |
@jancborchardt I've changed the headings, but I think leaving them in bold and adjust the color only looks better:
What do you think? |
A bit better I agree. |
@korelstar right, that’s also fine for now. :) (I’ll adjust other stuff at a later point and look at it again then.) |
@skjnldsv The original style ( |
I would say let’s take the opportunity to create it in nextcloud-vue then? What do you think @skjnldsv |
Ah you're right, we did not migrate the style yet ^^ https://github.com/nextcloud/nextcloud-vue/blob/master/src/components/AppNavigationItem/AppNavigationItem.vue |
Introduces labels for timeslots based on the last modified date, like we already have in the Android app and as discussed in nextcloud/notes-android#539
We have the following timeslots:
Month Year is used for all dates which are before the last month but only in this year and last year. Older notes are grouped in Year.
Please review @nextcloud/notes @nextcloud/designers