Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

group list of notes by timeslots #313

Merged
merged 2 commits into from May 24, 2019
Merged

group list of notes by timeslots #313

merged 2 commits into from May 24, 2019

Conversation

korelstar
Copy link
Member

Introduces labels for timeslots based on the last modified date, like we already have in the Android app and as discussed in nextcloud/notes-android#539

We have the following timeslots:

  • Today
  • Yesterday
  • This week
  • Last week
  • This month
  • Last month
  • [Month] [Year], e.g. April 2019
  • [Year], e.g. 2016

Month Year is used for all dates which are before the last month but only in this year and last year. Older notes are grouped in Year.

Screenshot 1

Screenshot 2

Please review @nextcloud/notes @nextcloud/designers

@korelstar korelstar added the enhancement New feature or request label May 23, 2019
@korelstar korelstar added this to the 3.0.0 milestone May 23, 2019
@korelstar korelstar merged commit b2520f3 into master May 24, 2019
@korelstar korelstar deleted the timeslots branch May 24, 2019 17:59
@korelstar korelstar added the feature: app navigation Related to the app navigation label May 25, 2019
@jancborchardt
Copy link
Member

@korelstar sorry for the late review! Looks very good, just 1 thing: Right now the headings are more important than the actual notes. Instead, these subheadings would be better in half-grey (color: var(--color-text-maxcontrast);) and not bold → like in the Mail app for the mail accounts.

@korelstar
Copy link
Member Author

Currently, it's just the default style for navigation labels from server. But I will change that ... Thanks :-)

@jancborchardt
Copy link
Member

@korelstar yes, we need to standardize that. :) cc @nextcloud/vue – but implementation (in several use-cases) comes before standardization. :) Thank you!

@korelstar
Copy link
Member Author

@jancborchardt I've changed the headings, but I think leaving them in bold and adjust the color only looks better:

bold normal
Screenshot Screenshot

What do you think?

@skjnldsv
Copy link
Member

skjnldsv commented Jun 7, 2019

A bit better I agree.
@korelstar when Jan approves, could you send your edit to the vue components? :)

@jancborchardt
Copy link
Member

@korelstar right, that’s also fine for now. :) (I’ll adjust other stuff at a later point and look at it again then.)

@korelstar
Copy link
Member Author

@skjnldsv The original style (app-navigation-caption) is not in nc-vue but in server. Should we change this in server? Or should we copy the style to nc-vue in order to be independent from server? Or should we have two style: one for "important" headings (like in category list) and one for "non-important" headings (like in this timeslot list)?

@jancborchardt
Copy link
Member

I would say let’s take the opportunity to create it in nextcloud-vue then? What do you think @skjnldsv

@skjnldsv
Copy link
Member

skjnldsv commented Jun 7, 2019

Ah you're right, we did not migrate the style yet ^^
@jancborchardt Yes that would be amazing!

https://github.com/nextcloud/nextcloud-vue/blob/master/src/components/AppNavigationItem/AppNavigationItem.vue
Also this would need a new AppNavigationCaption component (should be easy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature: app navigation Related to the app navigation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants