Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable27] fix: show error message for failing upload #2554

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Jul 22, 2024

How to reproduce

  • Nextcloud 27 or 26
  • Delete the photos directory in your home directory
  • Try uploading a photo in the album view
  • It will fail, because the photos directory does not exist but no error message is shown

Photos for Nextcloud 28 will create the missing folder automatically.
I decided against a backport because it was bigger refactoring.

Before:

Screencast.from.2024-07-22.11-17-36.webm

After:

Screencast.from.2024-07-22.11-15-48.webm

@kesselb kesselb requested a review from artonge July 22, 2024 09:21
@kesselb kesselb self-assigned this Jul 22, 2024
@kesselb kesselb added bug Something isn't working 2. developing Work in progress labels Jul 22, 2024
@kesselb kesselb added this to the Nextcloud 27.1.12 milestone Jul 22, 2024
@kesselb
Copy link
Contributor Author

kesselb commented Jul 22, 2024

/compile amend /

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the bug/noid/error-handling-for-failed-upload branch from 92b9805 to b3f3895 Compare July 22, 2024 13:02
@artonge artonge merged commit 7c0bcfb into stable27 Jul 22, 2024
34 checks passed
@artonge artonge deleted the bug/noid/error-handling-for-failed-upload branch July 22, 2024 14:14
@kesselb
Copy link
Contributor Author

kesselb commented Jul 22, 2024

/backport to stable26

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Jul 22, 2024
Copy link

backportbot bot commented Jul 22, 2024

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b backport/2554/stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick b3f38953

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2554/stable26

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress backport-request Pending backport by the backport-bot bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants