Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

continuous reload for public links #96

Closed
nextgen-networks opened this issue Oct 27, 2016 · 41 comments
Closed

continuous reload for public links #96

nextgen-networks opened this issue Oct 27, 2016 · 41 comments
Labels

Comments

@nextgen-networks
Copy link

nextgen-networks commented Oct 27, 2016

Polls Version: 0.7.2.1
NC Version: 10.0.1

Continuous reload does occur if polls will be accessed by public link without logon/user account.

Browser: Chrome 54.0.2840.71
2016-10-27-polls-reload-error_chrome

Browser: MS Edge
2016-10-27-polls-reload-error_edge

Browser: MS IE11
2016-10-27-polls-reload-error_ie11

@v1r0x
Copy link
Collaborator

v1r0x commented Oct 27, 2016

I'll have a look at it this weekend. Are your screenshots from different browsers? Does this occur on all browsers? Or is there anything in the screenshots I missed? 😄

@nextgen-networks
Copy link
Author

@v1r0x have updated original post with information about the different browser engines.

Thanks for your support!

@v1r0x
Copy link
Collaborator

v1r0x commented Oct 27, 2016

Does this only happen in IE11? Or in Edge/Chrome as well?

@nextgen-networks
Copy link
Author

:-) it does happen on all the Browser Versions mentioned above.
I tried several other client computer in the same and in remote/other networks and all behave the same way.

The error message in the top is an indicator for the continuous reload problem.
-> translated: "Problem while loading the website. Website will be reloaded in 5 seconds."

@v1r0x
Copy link
Collaborator

v1r0x commented Oct 27, 2016

I'm from germany, but thanks 😉
I thought you refer to the "Waiting for" in IE11.

Is there anything in the oc/nc logfile? And does it happen for all (e.g. new) public polls?

@v1r0x v1r0x added this to the 0.7.3 milestone Oct 27, 2016
@nextgen-networks
Copy link
Author

... ok - there has no log entry created while doing the following actions:

  • delete old poll
  • setup new poll (public)
  • open public poll as anonymous/not logged in user and faced the reload problem

As there does not exist any "old" poll i've no possibility to check this scenario.

Thanks for your investigation!

@v1r0x
Copy link
Collaborator

v1r0x commented Oct 27, 2016

Did you check owncloud.log and nextcloud.log (If you've switched from oc to nc)?

I tested it with firefox and had no problems. I'll do some tests with chrome/ie and maybe there is something wrong...:)

@nextgen-networks
Copy link
Author

Only the nextcloud.log does exist and by now only with three share/dav relevant entries and four more from Rainloop webmail - so no issues documented by the polls plugin.

@v1r0x
Copy link
Collaborator

v1r0x commented Oct 28, 2016

This is very weird. Is there anything in the browser's javascript console?

@nextgen-networks
Copy link
Author

@v1r0x:
Sorry for the delay - here is what chromes console told me:

2016-11-03_polls_continuous_reload_console-output

@v1r0x
Copy link
Collaborator

v1r0x commented Nov 3, 2016

Does this only happen in the polls app? Because the error in the console is caused by the apporder app, but maybe this error is unrelated to the reload error.

@nextgen-networks
Copy link
Author

YOU ARE MY MAN! Thanks for the the sharp view to the log!
It's definitely related to app order and i think it's caused by it.

Workaround:
deactivate AppOrder

Possible solution:
Allow non authenticated users the access to AppOrder to avoid reload.

@v1r0x
Copy link
Collaborator

v1r0x commented Nov 3, 2016

Glad it works now :)

Best would be to open an issue at the apporder repo. Don't know if there is something I could do about it.

@nextgen-networks
Copy link
Author

... jipp - typing the latest infos to an new ticket already ;-)

Thanks for your time and patience!

... and for your app!!!

@juliusknorr
Copy link
Member

@v1r0x I think this should be fixed in the polls app, as other public pages (like in the gallery app) do not produce this error.

From juliusknorr/apporder#24

I just had a quick look, but it looks like the TemplateResponse constructor in your controller needs an additional parameter ($renderAs='guest') for public pages. I'm sorry I cannot test that right now, but I'll do so if i find some time.

The current public page of the polls app also shows elements like the user menu on the left, which should not be visible for non logged in users.

@v1r0x
Copy link
Collaborator

v1r0x commented Nov 6, 2016

Thanks for your reply and your suggestion. Will test your solution. Thanks!

@nextgen-networks
Copy link
Author

reopen based on feedback of @juliushaertl

@v1r0x
Copy link
Collaborator

v1r0x commented Nov 16, 2016

@juliushaertl I added 'guest' as parameter after the parameter array return new TemplateResponse('polls', 'goto.tmpl', [], 'guest'); but the result looks really weird.
guest-poll
Any idea what's wrong?

@juliusknorr
Copy link
Member

@v1r0x Ok, it should be 'base' not 'guest', sorry for the wrong information.

After testing, i saw that this will render the public pages, but will not show the top bar with logo.
Other apps with public pages, like the gallery app or even the shipped files_sharing for example add a custom template with the header bar.

https://github.com/nextcloud/gallery/blob/master/templates/public.php#L49-L69
https://github.com/nextcloud/server/blob/master/apps/files_sharing/templates/public.php#L37-L73

@v1r0x v1r0x modified the milestones: 0.7.4, 0.7.3 Apr 29, 2017
@dartcafe
Copy link
Collaborator

@v1r0x Is that issue still an issue?

@v1r0x
Copy link
Collaborator

v1r0x commented Sep 18, 2017

I don't know, but I think yes. Haven't decided yet which template for not logged-in users is the best. Looks like every other app has another template...

@dartcafe
Copy link
Collaborator

dartcafe commented Sep 18, 2017

As far as I saw, the public pages are ok, besides the fact, that there are navigation elements, which don‘t work, because the user is not logged in. I just find the topic of the issue is a little bit confusing. But is related to #140

@dartcafe
Copy link
Collaborator

@nextgen-networks @v1r0x: This Issues still points to the 0.7.4 milestone. I cannot reproduce this. Is this bug still present or could we close the PR?

@dartcafe dartcafe removed this from the 0.7.4 milestone Oct 22, 2017
@jochen1205
Copy link

jochen1205 commented Nov 12, 2017

Unfortunately bug is still present. Owncloud 10.0.3; Polls 0.8.0
Checked on several browsers on mobile and Desktop: Firefox, Safari, Chrome

@muhackl
Copy link

muhackl commented Dec 7, 2017

Same issue here. Owncloud 10.0.3; Polls 0.8.0.
Safari, Chrome (Mac)
Chrome output:
screen

@splitt3r
Copy link
Contributor

splitt3r commented Dec 7, 2017

Does this happen in any other app? Is there anything special about this poll / the user the avatar fails to load for? Could you create an public poll to show us the issue / an account?

@muhackl
Copy link

muhackl commented Dec 7, 2017

This happens just in the polls app.
And it just appears, if I set the poll public or hidden.
But it does not depend, if user names are anonymous or not.
As soon as I am logged in and open the poll, the error does not occur.
Any clues?

@dartcafe
Copy link
Collaborator

dartcafe commented Dec 7, 2017

There seems to be some incopatibility with the avatarmanager, when the avatars are loaded via JS in public polls. I can reproduce this as well.

But I cannot see a relationship to the starting issue. Seesms to be a nother issue or do I understand something wrong?

@dartcafe
Copy link
Collaborator

dartcafe commented Dec 7, 2017

And BTW: I still cannot reproduce the starting issue.

@muhackl
Copy link

muhackl commented Dec 8, 2017

What exactly do you mean by „the starting issue“?
Any idea how to solve or workaroud this issue?

@dartcafe
Copy link
Collaborator

dartcafe commented Dec 8, 2017

This issue started with something around a continuous loading of the page in public polls (see screenshots). Something I cannot reproduce.

The last comments regard an issue related to not loading avatars and which I can reproduce. I cannot see a relationship between both things.

And no, I have no workaround for that at the moment. I will investigate next week. Maybe someone else can solve that faster or better.

@muhackl
Copy link

muhackl commented Dec 8, 2017

Well the relation is (but unfortunately I did not state this clearly): I get exactly the same error message and the same symptom as mentioned in the starting post: page reloads every 5 seconds (as announced in the error message).

@splitt3r
Copy link
Contributor

splitt3r commented Dec 8, 2017

Had a quick look and seems to be just another Nc vs. oC thing. Nc avatars are public https://github.com/nextcloud/server/blob/master/core/Controller/AvatarController.php#L115-L118 but oCs aren´t https://github.com/owncloud/core/blob/master/core/Controller/AvatarController.php#L107-L108. So we should check something like owncloud && public page and show the imageplaceholder instead of the avatar.

@dartcafe
Copy link
Collaborator

@muhackl Please try #266

@dartcafe
Copy link
Collaborator

@muhackl
Copy link

muhackl commented Dec 14, 2017

I changed the code of vote.js. After that, the 5-second-reload issue was no longer there. But there are no Dates shown any longer. Just zeros (0).
Another symptom I was watching already before this fix: When adding a new poll, I just chose several dates and just one time so I get one column. After one anonymous took part on the poll and I get back as admin to the edit mode of the poll, it looks like that (see attachment). There is something terribly wrong I think.
bildschirmfoto 2017-12-14 um 06 59 01

@dartcafe
Copy link
Collaborator

There are several changes since the 0.8.0. So better pull the 0.8.1 branch to test. Just updating a single file will have side effects. If the continuous erload will no more occur, I would prefer to close this littel issue with this huge amount of comments 😬

@muhackl
Copy link

muhackl commented Dec 14, 2017

Polls 0.8.1 fixed all issues for me.

  • 5-seconds-reload
  • Self-muliiplying rows
    Regarding me, issue can be closed.
    Thanks a lot!

@dartcafe
Copy link
Collaborator

👍 Great! Thanks.

@Byter3
Copy link

Byter3 commented Mar 4, 2019

Hi there!

I'm having this issue as well!

Any idea what is still wrong?
I'm running oc version 10.0.10.4
Poll version: 0.8.1

@dartcafe
Copy link
Collaborator

dartcafe commented Mar 6, 2019

Try the 0.8.3 Release. As mentioned in the readme, we dropped support for ownCloud. Sorry for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants