Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin approval #2

Closed
pellaeon opened this issue Aug 31, 2014 · 27 comments
Closed

Admin approval #2

pellaeon opened this issue Aug 31, 2014 · 27 comments

Comments

@pellaeon
Copy link
Collaborator

After user enters email (maybe additionally full name), a new pending entry is created, waiting for admin's approval.

After approval, verification email is sent, then the user could create account by clicking the link.

@pellaeon pellaeon self-assigned this Aug 31, 2014
@pellaeon pellaeon added this to the future milestone Aug 31, 2014
@KaeTuuN
Copy link

KaeTuuN commented Dec 28, 2014

This function would be very nice.

@tobiasnix
Copy link

I just posted a $5 bounty on Bountysource! https://www.bountysource.com/issues/4144723-admin-approval

@Mr-HeBo
Copy link

Mr-HeBo commented Aug 19, 2015

Yes please! Admin approval would be a very desirable option!!

@pellaeon
Copy link
Collaborator Author

pellaeon commented Sep 3, 2015

This is a work in progress on branch admin-approval

@cdamken
Copy link
Contributor

cdamken commented Oct 12, 2015

What a I do as workaround is that all new users comes to the "new" group, from there I can manage which should I move to "real" users.

The field with a full name would be good!

@WaaromZoMoeilijk
Copy link
Member

Same as carlos but i set the storage limit to 1kb so nothing can be
uploaded until "approval". I would love the real deal though! Great work on
the app!

Op di 13 okt. 2015 01:49 schreef Carlos Damken notifications@github.com:

What a I do as workaround is that all new users comes to the "new" group,
from there I can manage which should I move to "real" users.

The field with a re


Reply to this email directly or view it on GitHub
#2 (comment)
.

Met vriendelijke groet,

E. Holm

@pellaeon
Copy link
Collaborator Author

After discussions at ownCloud conf, decisions are made to change the registration flow, in order to be more straight-forward and simple.

There are 2 alternatives to choose from:

New registration flow A

  1. User clicks the verification link in the email, leads to a account creation form
  2. On the form: email (disabled), full name, username, password
  3. After submitting the form, user is informed "your account is pending approval"
  4. Admin approves
  5. An email is sent to the user telling him/her account is created, and provide link to login page

But I guess user will likely forget his/her password by the time admin approves, so here's the alternate flow to prevent that. This flow is also less hacky, becasue flow A needs to write directly to ownCloud's user password.

New registration flow B

  1. User clicks the verification link in the email, leads to a account creation form
  2. On the form: email (disabled), full name, username
  3. After submitting the form, user is informed "your account is pending approval"
  4. Admin approves
  5. An email is sent to the user telling him/her the request is approved, and provide a link to to the password setting form
  6. On the form: email (disabled), full name (disabled), username (disabled), password
  7. User submits the form, gets logged in directly

@cdamken @tobiasnix What do you all think?

@pellaeon
Copy link
Collaborator Author

Subtasks:

  • Admin approval interface, integrated with ownCloud's user administration page, partially completed, see admin-approval branch
  • New database schema is needed to accomadate full name and password (flow A), this entry will be deleted once a new account is created

@tobiasnix
Copy link

As there is a native password reset feature in owncloud i am voting for flow A. Its one step less for users who remember their password.

@WaaromZoMoeilijk
Copy link
Member

Would also go for A although B seems workable. You could include the reset password link in the email maybe?

Another option would be to add the password to the registration email, but I find it quite insecure when sites do that, never know for sure if someone's mail server is using ssl/tls.

The workaround still works for me, user group validation has no apps, 1kb storage, they get the notification upon login that their storage is full. Only problem is that they have access to the file sharing, which can't be disabled for usergroups. Which in turn makes the validation group able to view registered users, of what I can think would be a not wanted problem for some OwnCloud hosts.

Could you give me an update how?

Regards

@pellaeon
Copy link
Collaborator Author

I thought of a new simplified flow:

On first form, user inputs:

  • email
  • desired username
  • display name
  • password

Validation email is sent to the user, notification is sent to the admin.

  1. If the user validates email before admin decides, a message is shown to user "email validated, pending admin approval". When the admin approves/denies an additional email is sent to user.
  2. If the user validates email after admin approves, he is shown "email validated, logging you in" and redirected to files app.
  3. If admin denies before user validates, when the admin denies, user is notified. Admin can also drop the signup directly, user won't be notified.
  4. If admin approval feature is turned off, the flow is same as 2

@danielepercivaldi
Copy link

A (less 'burocracy'). I agree with @tobiasnix .

@georgygoshin
Copy link

Can't find this feature (admin approve required) in the latest nextcloud, how to get it on?

@pellaeon
Copy link
Collaborator Author

@georgygoshin It's still a work in progress.

@jasonehines
Copy link

I'd also like this feature

@githubos1
Copy link

githubos1 commented May 17, 2017

May I suggest that in the process of approval by admin, the registered users e-mail will automatically be added to the user database ?? currently that seems not the case... all users e-mail settings are empty...

edit:
the user email address is empty on the users login profile... but it is visible on the admin user manager screen... that's strange ...

registration app: 0.2.4
server: 12.0 beta3

Regards,
Oliver

@haug-den-lucas
Copy link

Are there any updates on this?

@derBobby
Copy link

derBobby commented Mar 8, 2018

Also interested!

@manureini
Copy link

I'm working on it. But I'm currently really busy.
So if you are a dev and you want to help:
https://github.com/lordmampf/registration

@cdamken
Copy link
Contributor

cdamken commented Mar 29, 2018

I'm working on it. But I'm currently really busy.
So if you are a dev and you want to help:
https://github.com/lordmampf/registration

I can help to test it, just let me know when you have some advances and I can help.

@Marcel-a
Copy link

I'm also interested in that feature.

@lordmampf I can help you. I've just downloaded the code.

@manureini
Copy link

@MarcelAlers

Thanks for your pr on my fork ;)
Is Admin approval working so far on your installation?

@andreadelutti
Copy link

I am also interested in this feature... Thanks

@Mardiie
Copy link

Mardiie commented May 3, 2019

If you ask me this needs to be in before this is usable on the open web without workarounds like a group with no storage space!

@intika
Copy link

intika commented Nov 26, 2019

On the current implementation there is no way to view pending users that had not confirmed their email (other than the database)

It would be nice if pending registration would be displayed on the config page...

Thanks :)

@nickvergessen
Copy link
Member

On the current implementation there is no way to view pending users that had not confirmed their email (other than the database)
It would be nice if pending registration would be displayed on the config page.

Can you create a new issue for that?
I would close this one here, because admin approval now already exists.

@mk3-v8
Copy link

mk3-v8 commented May 31, 2023

Can we have a field where we can assign approval by specific groups such as "Help Desk" in our case so they can manage the account creation process not only the administrator?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests