-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add headers for wasm support #3260
Conversation
juliusknorr
commented
Oct 26, 2023
•
edited
Loading
edited
- Figure out actually required headers
b146d4d
to
5b74d30
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
cac5f43
to
56769cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested regular case (not WASM): works as expected, downloading the files work
I don't have setup for WASM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @juliushaertl.
Looks good to me. @caolanm, any concerns?
no concerns, this seems to give us what we want without disrupting existing setups |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea about wasm, but code changes look sensible.
which was added in: CollaboraOnline/online#7784 Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
56769cd
to
571472e
Compare
Amended a small change to only set the allowEvalWasm if wasm support is indicated by the capabilities. |
yes, sensible |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
These headers are added to all Nextcloud apps by richdocuments which causes the News app to fail to show feed icons. I solved this by commenting out that part of richdocuments but that's a crude hack. These headers should only be inserted when the richdocuments app is active and in use in the current session, not when other apps are in the foreground. As to how to achieve this I have not found a good solution yet but maybe I'm overlooking something? |
Can you please file a new issue about this? It could be that we apply those too widely. Just a sidenote: Wouldn't it be better to fetch the icons on the backend and cache them on the Nextcloud side? That way the request would be also hiding the individual user ips and avoid loading remote content directly. |