Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: emit allow attribute on all iframes for the clipboard (related t… #3480

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

vmiklos
Copy link
Contributor

@vmiklos vmiklos commented Feb 20, 2024

…o #3474)

The unhandled cases were:

  • read-only view

  • view a past revision

  • for completeness, also adapt the iframe in files.js

…nextcloud#3474)

The unhandled cases were:

- read-only view

- view a past revision

- for completeness, also adapt the iframe in files.js

Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
@vmiklos
Copy link
Contributor Author

vmiklos commented Feb 20, 2024

@juliushaertl could you please review this? Thanks.

This adds the 'allow' attribute at the remaining places. I'm not sure what the files.js case is about, so I just did that for completeness. If you have a guess, I would be happy to learn. :-)

Other than that, please also merge the PR if you approve, I'm not a maintainer in this repo.

@juliusknorr
Copy link
Member

This adds the 'allow' attribute at the remaining places. I'm not sure what the files.js case is about, so I just did that for completeness. If you have a guess, I would be happy to learn. :-)

That is still some legacy code as the public share links of files are not migrated to Vue.js yet, so we have two different implementations for launching the iframe. Hopefully gets obsolete at some point and can just use Viewer.vue

@juliusknorr juliusknorr merged commit ffeee6a into nextcloud:main Feb 20, 2024
44 checks passed
@juliusknorr
Copy link
Member

/backport to stable28

@juliusknorr
Copy link
Member

/backport to stable27

@juliusknorr
Copy link
Member

/backport to stable26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants