Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming a file opens the sidebar #18613

Closed
jancborchardt opened this issue Dec 31, 2019 · 3 comments
Closed

Renaming a file opens the sidebar #18613

jancborchardt opened this issue Dec 31, 2019 · 3 comments
Labels
1. to develop Accepted and waiting to be taken care of bug feature: file sidebar Related to the file sidebar component good first issue Small tasks with clear documentation about how and in which place you need to fix things in. papercut Annoying recurring issue with possibly simple fix.

Comments

@jancborchardt
Copy link
Member

Steps to reproduce

  1. Rename a file or folder
  2. Press enter to submit the renaming

Expected behaviour

File is renamed and that’s that.

Actual behaviour

File is renamed but also the sidebar is opened for some reason. That’s unnecessary and especially annoying when on a small screen and you want to rename some more files and you have to close the sidebar again and again.

Server configuration

Latest server beta

@jancborchardt jancborchardt added bug 1. to develop Accepted and waiting to be taken care of papercut Annoying recurring issue with possibly simple fix. feature: file sidebar Related to the file sidebar component labels Dec 31, 2019
@gary-kim gary-kim added the good first issue Small tasks with clear documentation about how and in which place you need to fix things in. label Dec 31, 2019
@gary-kim

This comment has been minimized.

@gary-kim
Copy link
Member

gary-kim commented Jan 7, 2020

Took a second to look at this again. Looks like its slightly more complicated.
@skjnldsv #15719 removed the show argument for _updateDetailsView so the second argument as indicated by the jsdoc annotation is now ignored. Just want to check with you that that wasn't intentional?
The fix should be adding the following back into the _updateDetailsView function.

			// show defaults to true
			show = _.isUndefined(show) || !!show
			if (!show && OCA.Files.Sidebar.file === '') {
				return
			}

_updateDetailsView: function(fileName) {
if (!(OCA.Files && OCA.Files.Sidebar)) {
console.error('No sidebar available');
return;
}
if (!fileName) {
OCA.Files.Sidebar.close()

@skjnldsv
Copy link
Member

skjnldsv commented Jan 7, 2020

I guess not @gary-kim !
I don't recall this, so it's most likely a mistake on my side!

juliusknorr added a commit that referenced this issue Jan 8, 2020
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr added a commit that referenced this issue Jan 8, 2020
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr added a commit that referenced this issue Jan 13, 2020
Signed-off-by: Julius Härtl <jus@bitgrid.net>
skjnldsv pushed a commit that referenced this issue Jan 14, 2020
Signed-off-by: Julius Härtl <jus@bitgrid.net>
skjnldsv pushed a commit that referenced this issue Jan 14, 2020
Signed-off-by: Julius Härtl <jus@bitgrid.net>
skjnldsv pushed a commit that referenced this issue Jan 14, 2020
Signed-off-by: Julius Härtl <jus@bitgrid.net>
skjnldsv pushed a commit that referenced this issue Jan 14, 2020
Signed-off-by: Julius Härtl <jus@bitgrid.net>
skjnldsv pushed a commit that referenced this issue Jan 15, 2020
Signed-off-by: Julius Härtl <jus@bitgrid.net>
rullzer pushed a commit that referenced this issue Jan 15, 2020
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of bug feature: file sidebar Related to the file sidebar component good first issue Small tasks with clear documentation about how and in which place you need to fix things in. papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Development

No branches or pull requests

4 participants