Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate OCP\Remote? #25780

Closed
LukasReschke opened this issue Feb 24, 2021 · 3 comments · Fixed by #27700
Closed

Deprecate OCP\Remote? #25780

LukasReschke opened this issue Feb 24, 2021 · 3 comments · Fixed by #27700
Assignees
@icewind1991
Labels
3. to review Waiting for reviews technical debt

Comments

@LukasReschke
Copy link
Member

I don't find any usage of these classes in our GitHub organization as per https://sourcegraph.com/search?q=repo%3Agithub.com%2Fnextcloud%2F+OCP%5CRemote+count%3A1000&patternType=literal

Can we deprecate it so we have one less API to maintain? :)

Ref #6651
@LukasReschke
Copy link
Member Author

@icewind1991 thoughts? You seem to have added them and probably have the most context if we need to keep them or not.

@skjnldsv skjnldsv added the 0. Needs triage Pending check for reproducibility or if it fits our roadmap label Mar 22, 2021
@szaimen
Copy link
Contributor

szaimen commented Jun 25, 2021

Any update here?

@icewind1991
Copy link
Member

fine by me

@szaimen szaimen added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap needs info labels Jun 25, 2021
LukasReschke added a commit that referenced this issue Jun 28, 2021
@LukasReschke
Deprecate OCP\Remote
a423aae 
This is unused.

Fixes #25780

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
@LukasReschke LukasReschke added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Jun 28, 2021
@LukasReschke LukasReschke mentioned this issue Jun 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@icewind1991 icewind1991

Labels
3. to review Waiting for reviews technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate OCP\Remote nextcloud/server
4 participants
@LukasReschke @icewind1991 @skjnldsv @szaimen