Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

archive_tar: Fails extracting specific app archives #26708

Closed
icedream opened this issue Feb 22, 2021 · 9 comments
Closed

archive_tar: Fails extracting specific app archives #26708

icedream opened this issue Feb 22, 2021 · 9 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap needs info stale Ticket or PR with no recent activity

Comments

@icedream
Copy link

pear/archive_tar currently contains code that rejects relative symlinks with references to parent folders that are inside TAR archives as described in pear/Archive_Tar#35 and pear/Archive_Tar#37 (dupe).

This leads to apps such as Social failing to install since they are falsely detected as extracting out-of-path.

I am creating this ticket merely to track this issue until a fix is released.

@icedream
Copy link
Author

This issue actually has already been fixed with 1.4.13. So I would suggest updating pear/archive_tar to this version.

@icedream
Copy link
Author

I have also seen there is already a dependabot merge nextcloud/3rdparty#622 for this. This MR should fix the issue.

@MorrisJobke MorrisJobke transferred this issue from nextcloud/3rdparty Apr 22, 2021
@szaimen szaimen added the 0. Needs triage Pending check for reproducibility or if it fits our roadmap label May 20, 2021
@szaimen
Copy link
Contributor

szaimen commented Jul 6, 2021

Is this Issue still valid in NC21.0.3? If not, please close this issue. Thanks! :)

@icedream
Copy link
Author

icedream commented Jul 7, 2021

I'm closing this issue since we don't seem to be running into it on the newest version anymore. Thanks!

@icedream icedream closed this as completed Jul 7, 2021
@marcelklehr marcelklehr reopened this Aug 23, 2021
@marcelklehr
Copy link
Member

marcelklehr commented Aug 23, 2021

I have come across this issue again in v21: nextcloud/recognize#52
Can we backport the fix to v21?

@ghost
Copy link

ghost commented Sep 25, 2021

This issue has been automatically marked as stale because it has not had recent activity and seems to be missing some essential information. It will be closed if no further activity occurs. Thank you for your contributions.

@ghost ghost added the stale Ticket or PR with no recent activity label Sep 25, 2021
@szaimen
Copy link
Contributor

szaimen commented Sep 25, 2021

Should be fixed in the next release

@szaimen szaimen closed this as completed Sep 25, 2021
@marcelklehr
Copy link
Member

One of my users just hit this error again with v23.0.4: nextcloud/recognize#198

@dontinelli
Copy link

I have same error with v25.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap needs info stale Ticket or PR with no recent activity
Projects
None yet
Development

No branches or pull requests

4 participants