Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filetype filters on top of the files list (doc, pdf, jpg, ...) #45437

Closed
artonge opened this issue May 22, 2024 · 14 comments · Fixed by #45708
Closed

Filetype filters on top of the files list (doc, pdf, jpg, ...) #45437

artonge opened this issue May 22, 2024 · 14 comments · Fixed by #45708
Assignees
Milestone

Comments

@artonge
Copy link
Contributor

artonge commented May 22, 2024

@nextcloud/designers for mockups

@artonge artonge self-assigned this May 22, 2024
@szaimen szaimen self-assigned this May 22, 2024
@marcoambrosini marcoambrosini self-assigned this May 22, 2024
@szaimen
Copy link
Contributor

szaimen commented May 22, 2024

Example from google drive:
image

@jospoortvliet
Copy link
Member

@marcoambrosini wanted, in general, to also look at the search bar, but this brings in a whole 'what to do with search' discussion. Best that design comes up with a complete concept.

@susnux susnux self-assigned this May 28, 2024
@artonge
Copy link
Contributor Author

artonge commented May 29, 2024

@nextcloud/designers can we have some proper mockups for that?

@artonge artonge removed their assignment May 29, 2024
@marcoambrosini
Copy link
Member

marcoambrosini commented Jun 3, 2024

Kickoff call outcome @AndyScherzinger @artonge @susnux @szaimen

  • We start with filters but with taking into account that in the future we might add a search bar
  • More than just file type: also add "people" and "modified" like google
  • We keep the filters just above the files list and below all rich documents and recommended files
    Open question: do these filters only filter the current folder or are they recursive?
    E.g. when I filter for "documents" in a folder, do I see all documents in the whole folder tree or just the ones present in the current folder? From a UX perspective I think the former is the most beneficial, but it's much more difficult to achieve technically. It's also what our competitors do when using these filters. @susnux suggested that there could be a switch between current folder and all subfolder filtering.
    From a visual design perspective little will change regardless of what we choose so we go ahead with the mockups

Also cc @karlitschek and @jancborchardt

Current rough idea of the worst case scenario (Recommended files in root folder + rich workspaces enabled)

Image

Current rough idea of the best case scenario (subfolder with no rich workspaces)

Image

@jancborchardt
Copy link
Member

@marcoambrosini seems good, some feedback:

  • Can we just call it "Type" instead of "File type", much nicer and compact.
  • The dropdowns have some uniform width which looks off with the extra whitespace between text and down arrow. Would look nicer if it’s only as wide as needed.
  • How does it look when the dropdowns are opened? I assume either like in Google Drive or in our search, but would be good to clarify.

Open question: do these filters only filter the current folder or are they recursive?
E.g. when I filter for "documents" in a folder, do I see all documents in the whole folder tree or just the ones present in the current folder? From a UX perspective I think the former is the most beneficial, but it's much more difficult to achieve technically. It's also what our competitors do when using these filters. @susnux suggested that there could be a switch between current folder and all subfolder filtering.

I would first go with what is doable technically in a nice way, we can always improve on that. But no to a switch between modes here, that would needlessly complicate it.

@susnux
Copy link
Contributor

susnux commented Jun 5, 2024

susnux suggested that there could be a switch between current folder and all subfolder filtering.

I would first go with what is doable technically in a nice way, we can always improve on that. But no to a switch between modes here, that would needlessly complicate it.

To clarify for me it is about having two options:

  1. Filter the current folder (e.g. if there are a lot of file, I know the folder but I just want to filter)
  2. Search for something (e.g. search for a PDF somewhere in the file tree

@susnux
Copy link
Contributor

susnux commented Jun 5, 2024

Questions:
What file type filters do we use?
All types we found in the list? Or a generic list like

  • folders
  • documents (like office, spreadsheets and presentations)
  • Images
  • Videos
  • Audio

(this list would be easy to implement)

Or more like specific files? (PDF, JPG...)

What does "Modified" filter? "yesterday" "last week"?

People: Should this only filter the owner?

@jancborchardt
Copy link
Member

@susnux for all of these, I would follow Google Drive’s lead since that’s the solution spearheading this. cc @marcoambrosini

@susnux
Copy link
Contributor

susnux commented Jun 5, 2024

I started implementing it, but have a question:
The mock up is using a drop down, shall we use it or go with actions?
Especially for user filtering a drop down would be a completely new component to allow two menu levels (1. user 2. "shared the file", "owned the file", etc)

With a drop down it looks like this:

Screencast_20240605_223801.webm

@marcoambrosini
Copy link
Member

marcoambrosini commented Jun 6, 2024

Screenshot 2024-06-06 at 10 56 40

Hi @susnux, I think we should go with actions like in the global search. The different look is because of the smaller border radii but I was thinking about the actions component.

@susnux
Copy link
Contributor

susnux commented Jun 7, 2024

@marcoambrosini with actions it could look like this:

out.mp4

@jancborchardt
Copy link
Member

@susnux nice! Could "Clear filter" go to the bottom of the action menu so the entries don’t all jump one down?

@susnux
Copy link
Contributor

susnux commented Jun 12, 2024

Could "Clear filter" go to the bottom of the action menu

Sure but then you need to scroll fully down to clear, is that ok?

@sorbaugh
Copy link
Contributor

sorbaugh commented Jul 3, 2024

The related PR: #45708

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

8 participants