[Bug]: ShareApiController currentuser property type issue #46081

aleixq · 2024-06-24T20:50:22Z

⚠️ This issue respects the following points: ⚠️

This is a bug, not a question or a configuration/webserver/proxy issue.
This issue is not already reported on Github OR Nextcloud Community Forum (I've searched it).
Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
I agree to follow Nextcloud's Code of Conduct.

Bug description

In
https://github.com/nextcloud/server/blob/master/apps/files_sharing/lib/Controller/ShareAPIController.php#L63C2-L63C30
the currentUser property is typed as string, but in constructor the parameter is signed as ?string $userId = null , so in some circumstances there is this error:
Exception":"TypeError, Cannot assign null to property OCA\\Files_Sharing\\Controller\\ShareAPIController::$currentUser of type string

Steps to reproduce

It happens when share api is used via webapppassword in nc 29

Expected behavior

Allow userId to be null when using createShare method setting the property type the same as the parameter type.

Installation method

None

Nextcloud Server version

29

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

Default user-backend (database)
LDAP/ Active Directory
SSO - SAML
Other

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

{
  "reqId": "2M3DAMpzQRlKeiad9X2L",
  "level": 3,
  "time": "2024-06-24T18:22:46+00:00",
  "remoteAddr": "188.77.44.131",
  "user": "--",
  "app": "index",
  "method": "OPTIONS",
  "url": "/index.php/apps/webapppassword/api/v1/shares",
  "message": "Cannot assign null to property OCA\\Files_Sharing\\Controller\\ShareAPIController::$currentUser of type string",
  "userAgent": "Mozilla/5.0 (X11; Linux x86_64; rv:128.0) Gecko/20100101 Firefox/128.0",
  "version": "29.0.2.2",
  "exception": {
    "Exception": "TypeError",
    "Message": "Cannot assign null to property OCA\\Files_Sharing\\Controller\\ShareAPIController::$currentUser of type string",
    "Code": 0,
    "Trace": [
      {
        "function": "__construct",
        "class": "OCA\\Files_Sharing\\Controller\\ShareAPIController",
        "type": "->"
      },
      {
        "file": "web/lib/private/AppFramework/Utility/SimpleContainer.php",
        "line": 83,
        "function": "newInstanceArgs",
        "class": "ReflectionClass",
        "type": "->"
      },
      {
        "file": "web/lib/private/AppFramework/Utility/SimpleContainer.php",
        "line": 128,
        "function": "buildClass",
        "class": "OC\\AppFramework\\Utility\\SimpleContainer",
        "type": "->"
      },
      {
        "file": "web/lib/private/AppFramework/Utility/SimpleContainer.php",
        "line": 146,
        "function": "resolve",
        "class": "OC\\AppFramework\\Utility\\SimpleContainer",
        "type": "->"
      },
      {
        "file": "web/lib/private/AppFramework/DependencyInjection/DIContainer.php",
        "line": 470,
        "function": "query",
        "class": "OC\\AppFramework\\Utility\\SimpleContainer",
        "type": "->"
      },
      {
        "file": "web/lib/private/AppFramework/DependencyInjection/DIContainer.php",
        "line": 442,
        "function": "queryNoFallback",
        "class": "OC\\AppFramework\\DependencyInjection\\DIContainer",
        "type": "->"
      },
      {
        "file": "web/lib/private/AppFramework/App.php",
        "line": 163,
        "function": "query",
        "class": "OC\\AppFramework\\DependencyInjection\\DIContainer",
        "type": "->"
      },
      {
        "file": "web/lib/private/Route/Router.php",
        "line": 338,
        "function": "main",
        "class": "OC\\AppFramework\\App",
        "type": "::"
      },
      {
        "file": "web/lib/base.php",
        "line": 1050,
        "function": "match",
        "class": "OC\\Route\\Router",
        "type": "->"
      },
      {
        "file": "web/index.php",
        "line": 49,
        "function": "handleRequest",
        "class": "OC",
        "type": "::"
      }
    ],
    "File": "web/apps/files_sharing/lib/Controller/ShareAPIController.php",
    "Line": 124,
    "message": "Cannot assign null to property OCA\\Files_Sharing\\Controller\\ShareAPIController::$currentUser of type string",
    "exception": {},
    "CustomMessage": "Cannot assign null to property OCA\\Files_Sharing\\Controller\\ShareAPIController::$currentUser of type string"
  }
}

Additional info

No response

The text was updated successfully, but these errors were encountered:

kesselb · 2024-06-25T10:43:18Z

Allow userId to be null when using

How is that supposed to? We need the userId to create the share.

aleixq · 2024-06-26T21:05:38Z

excuse me if i'm wrong but ¿ why then the constructor allows it to be null? or I am missing something?

kesselb · 2024-06-27T15:42:24Z

You are not wrong.

We usually use ?string for the userId because the userId can be null, for example when a controller has the PublicPage annotation. That's not the case here, we need the userId otherwise the controller cannot work.

Would you mind sending us a pull request with your suggested fix? I guess it's fine to update the type hint.

aleixq · 2024-06-27T21:11:07Z

Well, let me show the big frame. I found this issue when adapting the controller that extends the ShareApiController in the app webapppassword to allow the use of share api outside of nextcloud.

If we are trying to use the current controller in https://github.com/digital-blueprint/webapppassword/blob/main/lib/Controller/ShareAPIController.php

It arises:

{
  "reqId": "lbDsFwFLxAyTN4QFQJzx",
  "level": 3,
  "time": "2024-06-27T14:23:23+00:00",
  "remoteAddr": "x.x.x.x",
  "user": "--",
  "app": "index",
  "method": "OPTIONS",
  "url": "/index.php/apps/webapppassword/api/v1/shares",
  "message": "Cannot assign null to property OCA\\Files_Sharing\\Controller\\ShareAPIController::$currentUser of type string",
  "userAgent": "Mozilla/5.0 (X11; Linux x86_64; rv:128.0) Gecko/20100101 Firefox/128.0",
  "version": "29.0.2.2",
  "exception": {
    "Exception": "TypeError",
    "Message": "Cannot assign null to property OCA\\Files_Sharing\\Controller\\ShareAPIController::$currentUser of type string",
    "Code": 0,
    "Trace": [
      {
        "function": "__construct",
        "class": "OCA\\Files_Sharing\\Controller\\ShareAPIController",
        "type": "->"
      },
      {
        "file": "/web/lib/private/AppFramework/Utility/SimpleContainer.php",
        "line": 88,
        "function": "newInstanceArgs",
        "class": "ReflectionClass",
        "type": "->"
      },
      {
        "file": "/web/lib/private/AppFramework/Utility/SimpleContainer.php",
        "line": 133,
        "function": "buildClass",
        "class": "OC\\AppFramework\\Utility\\SimpleContainer",
        "type": "->"
      },
      {
        "file": "/web/lib/private/AppFramework/Utility/SimpleContainer.php",
        "line": 151,
        "function": "resolve",
        "class": "OC\\AppFramework\\Utility\\SimpleContainer",
        "type": "->"
      },
      {
        "file": "/web/lib/private/AppFramework/DependencyInjection/DIContainer.php",
        "line": 470,
        "function": "query",
        "class": "OC\\AppFramework\\Utility\\SimpleContainer",
        "type": "->"
      },
      {
        "file": "/web/lib/private/AppFramework/DependencyInjection/DIContainer.php",
        "line": 442,
        "function": "queryNoFallback",
        "class": "OC\\AppFramework\\DependencyInjection\\DIContainer",
        "type": "->"
      },
      {
        "file": "/web/lib/private/AppFramework/App.php",
        "line": 163,
        "function": "query",
        "class": "OC\\AppFramework\\DependencyInjection\\DIContainer",
        "type": "->"
      },
      {
        "file": "/web/lib/private/Route/Router.php",
        "line": 338,
        "function": "main",
        "class": "OC\\AppFramework\\App",
        "type": "::"
      },
      {
        "file": "/web/lib/base.php",
        "line": 1050,
        "function": "match",
        "class": "OC\\Route\\Router",
        "type": "->"
      },
      {
        "file": "/web/index.php",
        "line": 49,
        "function": "handleRequest",
        "class": "OC",
        "type": "::"
      }
    ],
    "File": "/web/apps/files_sharing/lib/Controller/ShareAPIController.php",
    "Line": 124,
    "message": "Cannot assign null to property OCA\\Files_Sharing\\Controller\\ShareAPIController::$currentUser of type string",
    "exception": {},
    "CustomMessage": "Cannot assign null to property OCA\\Files_Sharing\\Controller\\ShareAPIController::$currentUser of type string"
  }
}

If I change the type of currentUser property in web/apps/files_sharing/lib/Controller/ShareAPIController.php to match the __construct signature ( so set to private ?string currentUser), with current webapppassword implementation it shows:

  Missatge: Internal error: Failed to retrieve the default value
   Fitxer: /web/lib/private/AppFramework/Utility/ControllerMethodReflector.php
   Línia: 101


Traeback

#0 /web/lib/private/AppFramework/Utility/ControllerMethodReflector.php(101): ReflectionParameter->getDefaultValue()
#1 /web/lib/private/AppFramework/Http/Dispatcher.php(128): OC\AppFramework\Utility\ControllerMethodReflector->reflect()
#2 /web/lib/private/AppFramework/App.php(184): OC\AppFramework\Http\Dispatcher->dispatch()
#3 /web/lib/private/Route/Router.php(338): OC\AppFramework\App::main()
#4 /web/lib/base.php(1050): OC\Route\Router->match()
#5 /web/index.php(49): OC::handleRequest()
#6 {main}

Keeping currentUser property set to private ?string currentUser , if I use the same signature as files_sharing shareapicontroller for createShare method in the webapppassword shareapicontroller it works as it should.

solracsf · 2024-08-07T18:36:20Z

This error also pops-out on CI logs.
https://github.com/nextcloud/server/actions/runs/10289497926/job/28478362370?pr=47116#step:12:23

aleixq added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Jun 24, 2024

szaimen added the 29-feedback label Jun 24, 2024

aleixq mentioned this issue Jun 24, 2024

Files Sharing API breaks in Nc 28+ digital-blueprint/webapppassword#197

Closed

kesselb added the needs info label Jun 25, 2024

kesselb added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap needs info labels Jun 27, 2024

kernie mentioned this issue Aug 19, 2024

[Bug]: InvalidTokenException Token does not exist: token does not exist Renewing session token failed: Token does not exist: token does not exist #43214

Open

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Bug]: ShareApiController currentuser property type issue #46081

[Bug]: ShareApiController currentuser property type issue #46081

aleixq commented Jun 24, 2024

kesselb commented Jun 25, 2024

aleixq commented Jun 26, 2024

kesselb commented Jun 27, 2024

aleixq commented Jun 27, 2024

solracsf commented Aug 7, 2024

[Bug]: ShareApiController currentuser property type issue #46081

[Bug]: ShareApiController currentuser property type issue #46081

Comments

aleixq commented Jun 24, 2024

⚠️ This issue respects the following points: ⚠️

Bug description

Steps to reproduce

Expected behavior

Installation method

Nextcloud Server version

Operating system

PHP engine version

Web server

Database engine version

Is this bug present after an update or on a fresh install?

Are you using the Nextcloud Server Encryption module?

What user-backends are you using?

Configuration report

List of activated Apps

Nextcloud Signing status

Nextcloud Logs

Additional info

kesselb commented Jun 25, 2024

aleixq commented Jun 26, 2024

kesselb commented Jun 27, 2024

aleixq commented Jun 27, 2024

solracsf commented Aug 7, 2024