Allow options to be passed to FileList.createFile
#12990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 10, 2018
|
Closing this as discussed in #12989 Creating a new file should open it in edit view. |
|
@te-online Mind to rebase the branch? |
juliusknorr
approved these changes
Sep 14, 2019
te-online
force-pushed
the
feature/filelist-createfile-options
branch
from
c72b410
to
6301531
Compare
|
@juliushaertl Like that? 😅 |
|
Looks good, now it's just missing the sign-off message 😉 |
skjnldsv
approved these changes
Sep 15, 2019
…o` can be overridden. Signed-off-by: Thomas Ebert <thomas.ebert@te-online.net>
te-online
force-pushed
the
feature/filelist-createfile-options
branch
from
6301531
to
e47a7f0
Compare
|
Sorry! Should be fixed now :-) |
skjnldsv
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #12989
Summary: Allow options to be passed to
FileList.createFile, so thatscrollTocan be overridden.This could be a fix to allow apps using the
createFilemethod to disablescrollTobehavior and by that disabling opening of thedetailsViewoverlay.I don't like it very much, because
scrollTofor me doesn't imply that another view will be opened. But since I have no idea what others expect from this method, this is my safest bet, right now. Any help is of course appreciated 😊