Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement quickaccess removal for delete-action #14723

Closed
wants to merge 2 commits into from

Conversation

newhinton
Copy link
Contributor

closes #13963

This removes a folder from the quickaccess navigationbar before it is deleted.
It also removes every favorited subfolder of that given folder, so that no dead links are left in the sidebar.

@newhinton newhinton self-assigned this Mar 16, 2019
@newhinton newhinton added the 3. to review Waiting for reviews label Mar 16, 2019
@faily-bot
Copy link

faily-bot bot commented Mar 16, 2019

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 17094: failure

TESTS=ui-regression

@tacruc
Copy link
Contributor

tacruc commented Mar 19, 2019

Deleting seems to work fine, even in the recursive case, but it's getting into a wired state if you restore the deleted file.

So I had Test/test/bla and bla was favorite. Deleting Test works fine. Than going to the trashbin and restore Test leads to
image,
where expanding the favorite is not possible.

@newhinton
Copy link
Contributor Author

@tacruc That's a good hint for an edgecase! I have not considered that, i will look into it, thanks! :)

@rullzer rullzer added this to the Nextcloud 17 milestone Mar 20, 2019
@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Mar 27, 2019
@skjnldsv
Copy link
Member

Bump? :)

@MorrisJobke MorrisJobke mentioned this pull request Jul 16, 2019
28 tasks
@rullzer rullzer removed this from the Nextcloud 17 milestone Aug 14, 2019
@jancborchardt
Copy link
Member

This also happens for adding favorites, the quick access doesn’t update. Is this maybe related @newhinton? :)

@newhinton
Copy link
Contributor Author

i'll take a look at it when i give a try at #18607

@juliushaertl
Copy link
Member

@newhinton Any update on this one?

@juliushaertl juliushaertl added the stale Ticket or PR with no recent activity label Nov 17, 2020
@newhinton
Copy link
Contributor Author

ahh sorry, i completely forgot

since i need to fix my app for nc20 anyway, i'll take a look at this simultaneously
sorry for the delay

@ghost ghost removed the stale Ticket or PR with no recent activity label Nov 19, 2020
@LukasReschke
Copy link
Member

Closing as there has been no traction on this.

@skjnldsv skjnldsv deleted the fix/13963/deleteFolderFavorites branch March 14, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Favorites quick access list is not updated when a favorited file or folder is removed
7 participants