-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove type hint for AbstractTrash.getSize() #17609
Remove type hint for AbstractTrash.getSize() #17609
Conversation
int is not large enough on 32 bit systems see nextcloud#13160
As reference: #16636 |
The Problem with float is, that the Size loses its precision with a float type. The file size should never be represented by a float. I think the point where the float gets set should be fixed. As far as I understand the problem 32bit systems are limited to 4G file size. |
I don't know, but in this case a file size limit is irrelevant. The size of the trash is the sum of sizes of all files inside. That can easily exceed the 32 bit MAX int regardless of whether there is a size limit for individual files. |
This seems to be the same problem as with the zipresponse. I might be a general problem to handle the integer overflow conversion to float. |
See also #24137 |
Thanks for sending a pull request 👍 I'm closing this pull request due inactivity. |
Int is not large enough on 32 bit systems to represent the size of a large trash. This leads to errors when displaying the trash in the web.
See #13160