Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 2 chars on placeholder in old jquery avatars #19405

Closed

Conversation

matchish
Copy link
Contributor

@matchish matchish commented Feb 11, 2020

Closes #19335
Signed-off-by: Sergey Shliakhov husband.sergey@gmail.com

@gary-kim gary-kim added 3. to review Waiting for reviews bug labels Feb 14, 2020
@gary-kim gary-kim added this to the Nextcloud 19 milestone Feb 14, 2020
@gary-kim
Copy link
Member

@matchish Could you rebase your branch?

Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks ok, will review live after rebase

@matchish
Copy link
Contributor Author

Sorry forgot to rebase. I'll do it tomorrow

nextcloud#19335
Signed-off-by: Sergey Shliakhov <husband.sergey@gmail.com>
@matchish
Copy link
Contributor Author

@skjnldsv Rebased

@gary-kim
Copy link
Member

gary-kim commented Feb 25, 2020

/compile amend /

EDIT: 😕

@skjnldsv
Copy link
Member

@gary-kim I guess this is because it's a fork

@skjnldsv
Copy link
Member

/compile amend /

This was referenced Apr 4, 2020
This was referenced Apr 15, 2020
@rullzer rullzer mentioned this pull request Apr 23, 2020
11 tasks
@skjnldsv
Copy link
Member

Please rebase :)
And rebuild!

@ChristophWurst
Copy link
Member

I couldn't push to the forked remote, so I created a new PR at #20634 with the rebased & rebuilt version.

@rullzer
Copy link
Member

rullzer commented Apr 30, 2020

Done in #20634

@rullzer rullzer closed this Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Old jquery avatars are not using 2 chars on placeholder
5 participants