Use 2 chars on placeholder in old jquery avatars #19405
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matchish Could you rebase your branch? |
skjnldsv
reviewed
Feb 24, 2020
|
Sorry forgot to rebase. I'll do it tomorrow |
nextcloud#19335 Signed-off-by: Sergey Shliakhov <husband.sergey@gmail.com>
matchish
force-pushed
the
legacy-avatar-placeholder
branch
from
34ca225
to
a695851
Compare
|
@skjnldsv Rebased |
|
/compile amend / EDIT: 😕 |
|
@gary-kim I guess this is because it's a fork |
|
/compile amend / |
jancborchardt
requested review from
ChristophWurst,
skjnldsv,
gary-kim and
nickvergessen
skjnldsv
approved these changes
Apr 23, 2020
|
Please rebase :) |
gary-kim
approved these changes
Apr 23, 2020
|
I couldn't push to the forked remote, so I created a new PR at #20634 with the rebased & rebuilt version. |
|
Done in #20634 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19335
Signed-off-by: Sergey Shliakhov husband.sergey@gmail.com