Improvement of Exception info in File manipulation. #19558
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improvement of Exception through. Not tested. I do not have the mead. Signed-off-by: Denis Germa <denis.germa@free.fr>
Closed
dgedgedge
changed the title
kesselb
reviewed
Apr 5, 2020
| @@ -55,7 +55,7 @@ public function getContent() { | |||
| */ | |||
| return $this->view->file_get_contents($this->path); | |||
| } else { | |||
| throw new NotPermittedException(); | |||
| throw new NotPermittedException('Permission issue unable to get content of file ' . $this->path); | |||
There was a problem hiding this comment.
Permission issue unable to get content of file
I don't think so. We don't have permission to read the file.
| @@ -74,7 +74,7 @@ public function putContent($data) { | |||
| $this->fileInfo = null; | |||
| $this->sendHooks(array('postWrite')); | |||
| } else { | |||
| throw new NotPermittedException(); | |||
| throw new NotPermittedException('Permission issue unable to get content of file ' . $this->path); | |||
There was a problem hiding this comment.
We don't have permission to update a file here. Unable to get content of file is not correct.
| @@ -115,7 +115,7 @@ public function fopen($mode) { | |||
| $this->sendHooks($postHooks); | |||
| return $result; | |||
| } else { | |||
| throw new NotPermittedException(); | |||
| throw new NotPermittedException('Permission issue Could not open (Incorrect mode ' . $mode . ') ' . $this->path); | |||
There was a problem hiding this comment.
The mode is not incorrect. We don't have the required permissions to do that operation. Example: w+ requires us to have read and update permission for a file.
This was referenced Apr 9, 2020
Merged
Merged
Merged
|
Base repository was deleted. And there was no feedback since a while. Thus I will close this PR for now. It can be picked up later of course. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement of Exception through.
Not tested. I do not have the mean.
I did this to help debug an issue with nextcloud/Music application.
It hanged while scanning files.
Signed-off-by: Denis Germa denis.germa@free.fr