-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send coverage to codecov again #20198
Conversation
a29bd95
to
582a30a
Compare
4843ce1
to
cd78554
Compare
cd78554
to
a0fce7a
Compare
@kesselb What's the status here? :) |
a0fce7a
to
489acc1
Compare
For some builds the coverage is reported again to codecov 👻 Some lines (that are related to codecov on jobs with missing xdebug extension) are commented. I would like to keep them for now. Probably someone else want's to update the docker images (or even better switch to pcov) for the jobs without coverage. Feel free to move this to 20 (or remove the milestone). It's not really related to a release. |
3fd6782
to
7f9a5e8
Compare
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
9ae71ad
to
9d04ed6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense 👍
-Z
now: Exit with 1 if not successful. Default will Exit with 0. If for some reason xdebug is missing (or something else) those pipelines should fail.