Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send coverage to codecov again #20198

Merged
merged 1 commit into from
Jul 3, 2020
Merged

Send coverage to codecov again #20198

merged 1 commit into from
Jul 3, 2020

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Mar 27, 2020

  • Added the codecov token to drone secrets. That makes it easier to replace it.
  • The switch pull_request / no pull_request looked superfluous to me. https://github.com/codecov/codecov-bash/blob/ac57e523b06dd4381e6e872677e74b4f95c0939a/codecov#L666-L677 (only the commit seems to be missing).
  • Docker images used are not rebuild automatically hence php7.x:latest should work for most pipelines.
  • nodb-codecov and db-codecov use -Z now: Exit with 1 if not successful. Default will Exit with 0. If for some reason xdebug is missing (or something else) those pipelines should fail.

@kesselb kesselb changed the title Use latest docker image to run coverage. Codecov should fail if repor… Send coverage to codecov again Mar 27, 2020
@kesselb kesselb force-pushed the enh/enable-codecov branch 2 times, most recently from 4843ce1 to cd78554 Compare March 27, 2020 13:18
@kesselb kesselb added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 27, 2020
@kesselb kesselb added this to the Nextcloud 19 milestone Mar 27, 2020
.drone.yml Outdated Show resolved Hide resolved
This was referenced Apr 4, 2020
This was referenced Apr 15, 2020
@rullzer rullzer mentioned this pull request Apr 23, 2020
11 tasks
@georgehrke
Copy link
Member

@kesselb What's the status here? :)

@kesselb
Copy link
Contributor Author

kesselb commented Apr 24, 2020

For some builds the coverage is reported again to codecov 👻

Some lines (that are related to codecov on jobs with missing xdebug extension) are commented. I would like to keep them for now. Probably someone else want's to update the docker images (or even better switch to pcov) for the jobs without coverage.

Feel free to move this to 20 (or remove the milestone). It's not really related to a release.

@georgehrke georgehrke removed this from the Nextcloud 19 milestone Apr 24, 2020
@kesselb kesselb force-pushed the enh/enable-codecov branch 2 times, most recently from 3fd6782 to 7f9a5e8 Compare June 30, 2020 19:50
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense 👍

@rullzer rullzer merged commit 5e985c6 into master Jul 3, 2020
@rullzer rullzer deleted the enh/enable-codecov branch July 3, 2020 08:07
@MorrisJobke MorrisJobke added this to the Nextcloud 20 milestone Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants