Improve traces of invalid token exceptions #21122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
|
We should also log the exception in https://github.com/nextcloud/server/blob/master/lib/private/User/Session.php#L534, otherwise the exception message gets lost |
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
|
Done |
blizzz
approved these changes
May 27, 2020
gary-kim
approved these changes
May 27, 2020
georgehrke
approved these changes
May 27, 2020
blizzz
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help with issues like nextcloud/twofactor_totp#404 (comment).
In general a catch-and-throw-new should transport the previous exception. Otherwise the trace gets lost and debugging is more complicated than it needs to be.