Add action to clear all weather favorites #24194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-nc
requested review from
jancborchardt,
ChristophWurst,
juliushaertl,
GretaD and
skjnldsv
ChristophWurst
approved these changes
Nov 17, 2020
skjnldsv
approved these changes
Nov 17, 2020
juliushaertl
approved these changes
Nov 17, 2020
|
/compile amend / |
npmbuildbot-nextcloud
bot
force-pushed
the
enh/noid/clear-weather-favorites
branch
from
a02c1f0
to
da41399
Compare
|
I’d say we’re adding a bit too many controls here? :D We also e.g. don’t have the ability to "Remove all favorites" in e.g. Files or Talk, so we don’t really need that in the small weather widget? |
|
@jancborchardt I agree it makes the menu grow. I just thought it would be more convenient than to delete them one by one which is more fastidious than in Files. An alternative would be to provide a way to delete a favorite directly in the menu instead of having to select it and then press "remove from favorites". What do you think? Or we just keep it like that, fine by me 😁. |
julien-nc
force-pushed
the
enh/noid/clear-weather-favorites
branch
from
da41399
to
2216f1b
Compare
|
How about that? |
julien-nc
force-pushed
the
enh/noid/clear-weather-favorites
branch
from
2216f1b
to
c72d753
Compare
Sorry for the late reply – that is a nice solution! :) |
julien-nc
force-pushed
the
enh/noid/clear-weather-favorites
branch
from
c72d753
to
8f0fe6f
Compare
|
/compile amend / |
Signed-off-by: Julien Veyssier <eneiluj@posteo.net> Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
npmbuildbot-nextcloud
bot
force-pushed
the
enh/noid/clear-weather-favorites
branch
from
8f0fe6f
to
777fe3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small weather widget improvement allowing users to delete all favorites at once.