Properly check the data dir

[MorrisJobke]

• fixes Config htaccess.RewriteBase makes admin datadir check fail #1364

cc @nickvergessen @LukasReschke @rullzer

To test the setup check just comment out

server/lib/private/Setup.php

Line 499 in 506ccdb

file_put_contents($baseDir . '/.htaccess', $content);

and start the setup page.

To test the admin page check just remove the .htaccess file in the data dir and refresh ;)

[mention-bot]

@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @icewind1991 and @rullzer to be potential reviewers.

[nickvergessen]

then also kill the creation of this file

[MorrisJobke]

This was never created ;) (the server check creates it and kills it in the same call ;))

[LukasReschke]

LGTM

[codecov-io]

Current coverage is 57.32% (diff: 50.00%)

Merging #2513 into master will increase coverage by 0.09%

@@             master      #2513   diff @@
==========================================
  Files          1145       1202     +57   
  Lines         65670      72993   +7323   
  Methods        7365       7426     +61   
  Messages          0          0           
  Branches          0       1259   +1259   
==========================================
+ Hits          37585      41846   +4261   
- Misses        28085      31147   +3062   
  Partials          0          0           

Diff Coverage	File Path
0%	lib/private/legacy/util.php
•••••••••• 100%	core/js/setupchecks.js

Powered by Codecov. Last update 572b078...a2867c0

[rullzer]

Lets do this. 👍

[quenenni]

Hello,

I modified the 2 files but still have the same warning msg.
The call to "https://xxxxxxxxxxx/data/.ocdata?t=1481115617749" receives a response status of 200 and an empty responseText -> messages.push

Those things were checked:

• The file data/.ocdata exists and is accessible directly (not "Forbiden page" msg as it should be)
• The data/.htaccess file exists and should prevent the access to the data dir,
• The AllowOverride All is in the vhost directives,
• The "Require all denied" is set for "<Directory /data/>" in the vhost file,
• I tested that on a simple vhost, with just a data dir and the same .htaccess file => the access to the data dir is blocked.

[EDIT]
We just tested nginx instead of Apache and we don't have that message anymore.