-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move exception logging to separate field #27451
Conversation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense 👍
Do we have any place to mention noticable changes for admins in the changelog for example? Maybe something for @jospoortvliet ? |
Documentation pr in nextcloud/documentation#6764 |
|
Ah also about admins, ok then I'll add to that. |
This is a proposal to adjust the log format when exceptions are logged to move them to a separate field in the log json output. The current approach basically leads to the message field being either a string or an object which always bugged me a bit as it is not a unified format. This would also allow easier extraction for some log collection solutions when storing the log details in elastic search for example.
As it is a breaking change on the format we'd need to properly document that in the changelog.
Any oppinions @ChristophWurst @nickvergessen @MorrisJobke @skjnldsv @kesselb
Before:
After: