Correctly skip suppressed errors in PHP 8.0

[yan12125]

Applies the suggested transformation mentioned in
https://www.php.net/manual/en/migration80.incompatible.php,

The @ operator will no longer silence fatal errors (E_ERROR,
E_CORE_ERROR, E_COMPILE_ERROR, E_USER_ERROR, E_RECOVERABLE_ERROR,
E_PARSE). Error handlers that expect error_reporting to be 0 when
@ is used, should be adjusted to use a mask check instead

The new code still works on PHP 7, as error_reporting() already
returns 0 when diagnostics are suppressed.

This fixes #25807 in PHP 8.0.
For PHP 7.x, #22243 suppresses
the E_NOTICE message from the second session_start() call with the error
suppression operator @, and thus those E_NOTICE messages are still
logged in PHP 8.0.

See also #25806

Signed-off-by: Chih-Hsuan Yen yan12125@gmail.com

[yan12125]

As a side note: other error_reporting() calls in Nextcloud already uses the mask pattern

lib/private/Log/ErrorHandler.php:		if (!(error_reporting() & $number)) {
lib/base.php:			error_reporting(E_ALL);
apps/files/lib/Command/Scan.php:		if (!(error_reporting() & $severity)) {
apps/files/lib/Command/Scan.php:			// This error code is not included in error_reporting
apps/files/lib/Command/ScanAppData.php:		if (!(error_reporting() & $severity)) {
apps/files/lib/Command/ScanAppData.php:			// This error code is not included in error_reporting

[szaimen]

cc @skjnldsv, @eneiluj, @icewind1991 and @ArtificialOwl for feedback on this

[yan12125]

Hmm I'm not sure if I understand the failed test. Drone CI [1] reports that "And I see that the new user form is shown" failed, while the new user form seems fine with my patched installation.

[1] https://drone.nextcloud.com/nextcloud/server/6543/62/4

[yan12125]

After rebasing onto the latest git-master, the acceptance-login test becomes green but sqlite and integration-sharing-v1-video-verification turn red. I think those are unstable tests like ones listed in #22305

[AndyXheli]

Tested on NC 22 and looks good.

[juliushaertl]

Makes sense 👍

[szaimen]

Not sure if this is important:

There was 1 failure:
407 |  
408 | 1) Test\Files\Cache\UpdaterLegacyTest::testWrite
409 | Failed asserting that 1624596572 is equal to 1624596573 or is greater than 1624596573.
410 |  
411 | /drone/src/tests/lib/Files/Cache/UpdaterLegacyTest.php:118

[yan12125]

Checking again, the failure in UpdaterLegacyTest.php is mentioned as an unstable test at #22305 (comment)

[yan12125]

Hmm, how can I proceed here? GitHub refuses to merge this PR as some tests failed.

Also, could this be backported to versions that declare PHP 8 support (stable-22 and stable-21)?

[skjnldsv]

Can you rebase to master please @yan12125 ?

[yan12125]

Can you rebase to master please @yan12125 ?

Done! Previous failures are green this time, but there is a new failure, and it is not mentioned in #22305

  Scenario: users navigation without disabled users                                   # /drone/src/tests/acceptance/features/users.feature:48
    Given I act as Jane                                                               # ActorContext::iActAs()
    And I am logged in as the admin                                                   # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the User settings                                                      # SettingsMenuContext::iOpenTheUserSettings()
    And I open the "Disabled users" section                                           # AppNavigationContext::iOpenTheSection()
    And I see that the list of users contains the user disabledUser                   # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
      The user disabledUser in the list of users is not shown yet after 100 seconds
    And I open the actions menu for the user disabledUser                             # UsersSettingsContext::iOpenTheActionsMenuOf()
    And I see that the "Enable user" action in the disabledUser actions menu is shown # UsersSettingsContext::iSeeTheAction()
    When I click the "Enable user" action in the disabledUser actions menu            # UsersSettingsContext::iClickTheAction()
    Then I see that the section "Disabled users" is not shown                         # AppNavigationContext::iSeeThatTheSectionIsNotShown()
    When I open the User settings                                                     # SettingsMenuContext::iOpenTheUserSettings()
    Then I see that the section "Disabled users" is not shown                         # AppNavigationContext::iSeeThatTheSectionIsNotShown()

[nickvergessen]

That's okay and unrelated I think

[yan12125]

Thanks! But GitHub still insists on green for all tests 😂

[juliushaertl]

/backport to stable22

[juliushaertl]

/backport to stable21

[backportbot-nextcloud]

The backport to stable21 failed. Please do this backport manually.

[backportbot-nextcloud]

The backport to stable22 failed. Please do this backport manually.

[yan12125]

Hmm strange. Created manual backports #27938 and #27939. Hopefully I'm doing it right :)

[juliushaertl]

Looks good :) Thanks for already taking care of that 👍

[yan12125]

Hmm is this needed on stable20? The latter does not declare support for PHP 8.0 [1]. I guess it will not bring errors, though.

[1] https://github.com/nextcloud/server/blob/stable20/lib/versioncheck.php

[MichaIng]

Ah that is true, if fails even when overriding the check, due to broader incompatibility. The bot is sleeping anyway 😄.